Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cli-cpp in sandbox after QpidConfig.cmake was fixed upstream #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build cli-cpp in sandbox after QpidConfig.cmake was fixed upstream #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,6 @@ cmake(
name = "cli-cpp",
generate_crosstool_file = False,

# Qpid Cpp has absolute paths in QpidConfig.cmake, can't use that
# Let's disable sandbox instead, and we'd need to fix in Qpid Cpp
#env = {
# "LDFLAGS": "-L$$EXT_BUILD_DEPS/qpid-cpp/lib64"
#},
tags = ["no-sandbox"],

cache_entries = {
"CMAKE_CXX_COMPILER": "g++",

Expand Down
13 changes: 13 additions & 0 deletions BUILD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,19 @@ Get more output with `--verbose_failures` flag.

Disable sandbox with `--spawn_strategy=standalone` flag, use values of `processwrapper-sandbox`, `linux-sandbox`, ...

Run `bazel sync` to redownload external dependencies (we reference `main` branches in `WORKSPACE`).

Check notice

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 99

Expected: 80; Actual: 99

##### Overriding repos

Check notice

Code scanning / Markdownlint (reported by Codacy)

Expected: 1; Actual: 0; Below

Expected: 1; Actual: 0; Below
Replace qpid-cpp external repo with (modified) local checkout `--override_repository=qpid-cpp=/home/jdanek/repos/qpid/qpid-cpp`.

In the directory, create empty `WORKSPACE` file and a `BUILD.bazel` file containing the following `filegroup` def

Check notice

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 113

Expected: 80; Actual: 113

```python

Check notice

Code scanning / Markdownlint (reported by Codacy)

Expected: indented; Actual: fenced

Expected: indented; Actual: fenced
filegroup(name = "all", srcs = glob(["**/*"]), visibility = ["//visibility:public"])
```

See <https://bazel.build/docs/external#overriding-repositories> for additional discussion.

### CMake build

If you want to use the dependencies built by Bazel in your CMake build, do this.
Expand Down