Fix ros-visualization#1825/ros-visualization#1830: segfault when hidi…

…ng deleted properties
rhaschke · May 18, 2024 · b7dbd41 · b7dbd41
1 parent 2db2c53
commit b7dbd41
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/rviz/properties/property.cpp b/src/rviz/properties/property.cpp
@@ -397,10 +397,7 @@ void Property::setModel(PropertyTreeModel* model)
   if (model_ && hidden_)
   {
     // process propertyHiddenChanged after insertion into model has finished
-    QTimer::singleShot(0, model_, [this]() {
-      if (model_)
-        model_->emitPropertyHiddenChanged(this);
-    });
+    QTimer::singleShot(0, this, [this]() { model_->emitPropertyHiddenChanged(this); });
   }
   int num_children = numChildren();
   for (int i = 0; i < num_children; i++)