Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, in another way #458

Closed
wants to merge 3 commits into from
Closed

Fix CI, in another way #458

wants to merge 3 commits into from

Conversation

muzimuzhi
Copy link
Contributor

The GitHub Docs source has taken the <code>...&lt;...&gt;...</code> to `...<...>...` changes 4 months ago, see github/docs@a15d261.

@rhysd
Copy link
Owner

rhysd commented Oct 16, 2024

Thank you for taking time to look into this.

However this is not a fix but a workaround not to make CI fail. The root cause is that goldmark has changed the behavior of Node.Text.

yuin/goldmark#471

This PR modifies the test data not to hit this issue. So after merging this PR, the issue is still there. You'll find that Node.Text calls cause bunch of warnings from staticcheck due to deprecation if you update goldmark to v1.7.8.

Making the test data follow the latest document is another maintenance work.

Since I already know the reason, I'll add a fix for this.

@rhysd rhysd closed this in b7d58f5 Oct 17, 2024
@muzimuzhi muzimuzhi deleted the fix-ci branch October 17, 2024 06:53
@rhysd
Copy link
Owner

rhysd commented Oct 17, 2024

I used the idea of 0c5f33d at 763f886 so I credit you at the commit.

@muzimuzhi
Copy link
Contributor Author

Thank you. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants