Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify additional custom HTTP headers #41

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

benweint
Copy link
Contributor

@benweint benweint commented May 27, 2022

This change adds the ability to attach additional HTTP headers to all outbound HTTP requests against the Kafka Connect REST API.

The motivating use case here is to support additional types of authentication beyond just HTTP basic auth, as requested in #39.

More specifically, my hope is to be able to consume this functionality within https://github.com/Mongey/terraform-provider-kafka-connect, which is a client of this library.

@benweint
Copy link
Contributor Author

benweint commented Jun 9, 2022

@EtienneGuerlais would you be willing to take a look at this one too?

Copy link
Collaborator

@EtienneGuerlais EtienneGuerlais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me, thanks again for contributing!
I will as for your previous PR give it one or two days then merge and create a release.

@EtienneGuerlais EtienneGuerlais merged commit a69a6c3 into ricardo-ch:master Jun 13, 2022
@benweint benweint deleted the set-header branch June 13, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants