perf: fix memory leak caused by invalid destroy (#18)

* In src/core/createCodeMirror.ts, onCleanup is modified * Remove package-lock.json * In dev/index.ts, Remove 200-rendering test * In dev/index.ts, Remove 200-rendering test
riccardoperra · Mar 13, 2023 · c5f2bd8 · c5f2bd8
1 parent 416b5b4
commit c5f2bd8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/core/createCodeMirror.ts b/src/core/createCodeMirror.ts
@@ -65,8 +65,8 @@ export function createCodeMirror(props?: Partial<CreateCodeMirrorProps>) {
       onMount(() => setEditorView(currentView));
 
       onCleanup(() => {
-        setEditorView(undefined);
         editorView()?.destroy();
+        setEditorView(undefined);
       });
     })
   );

diff --git a/src/core/createLazyCompartmentExtension.ts b/src/core/createLazyCompartmentExtension.ts
@@ -1,4 +1,4 @@
-import { Accessor, createEffect, createSignal, lazy } from 'solid-js';
+import { Accessor, createEffect, createSignal } from 'solid-js';
 import { Extension } from '@codemirror/state';
 import { EditorView } from '@codemirror/view';
 import { createCompartmentExtension } from './createCompartmentExtension';