-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 商品写真の登録機能を実装 #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
商品情報の変更処理が正しく行えていなかったので一度Draftにします |
sou1118
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BruCandy
approved these changes
Nov 18, 2024
3w36zj6
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #22
Summary
This pull request adds support for product images throughout the application. The most important changes include updates to the
ReceptionCard
andProductCard
components, modifications to the product creation process, and updates to the database schema to include the newimage
field.Component Updates:
app/components/organisms/reception/ReceptionCard.tsx
: Added animg
element to display product images and updatedPropTypes
to include the newimage
field. [1] [2] [3]app/components/organisms/register/ProductCard.tsx
: Modified the component to display product images and updatedPropTypes
to include the newimage
field. [1] [2]Product Creation:
app/crud/crud_products.ts
: Addedimage
field to the product creation function.app/routes/register.tsx
: Updated the product registration form to include an input for the image URL, and added validation for the newimage
field. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Type and Schema Updates:
app/type/typeproduct.ts
: Addedimage
field to theTypeProduct
type.prisma/schema.prisma
: Updated theProducts
model to include theimage
field.prisma/migrations/20241117135316_add_image_in_producs/migration.sql
: Created a migration to add theimage
field to theProducts
table.