Git apis on runtime #8575
Merged
Git apis on runtime #8575
+6,964
−858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
commented
Jan 7, 2026
k-anshul
commented
Jan 7, 2026
k-anshul
commented
Jan 7, 2026
k-anshul
force-pushed
the
more_git_apis
branch
from
1d5404a to
c52cd70
Compare
AdityaHegde
approved these changes
Jan 14, 2026
Collaborator
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Just a small nit. Otherwise LGTM
runtime/server/server.go
Outdated
| // NewServer creates a new runtime server. | ||
| // The provided ctx is used for the lifetime of the server for background refresh of the JWKS that is used to validate auth tokens. | ||
| func NewServer(ctx context.Context, opts *Options, rt *runtime.Runtime, logger *zap.Logger, limiter ratelimit.Limiter, activityClient *activity.Client) (*Server, error) { | ||
| func NewServer(ctx context.Context, opts *Options, rt *runtime.Runtime, logger *zap.Logger, limiter ratelimit.Limiter, activityClient *activity.Client, admin drivers.AdminService) (*Server, error) { |
Collaborator
There was a problem hiding this comment.
nit: admin => adminOverride . Otherwise passing nil in runtime/start to this feels incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/rilldata/issue/PLAT-373/support-git-operations-inside-the-runtime
Checklist: