Skip to content

fix: contains filter on a dimension does not support dimension comparision #8593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdityaHegde merged 1 commit into from
Jan 14, 2026
Merged

fix: contains filter on a dimension does not support dimension comparision #8593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions web-common/src/features/dashboards/time-series/multiple-dimension-queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { mergeDimensionAndMeasureFilters } from "@rilldata/web-common/features/dashboards/filters/measure-filters/measure-filter-utils";
import { includedDimensionValues } from "@rilldata/web-common/features/dashboards/state-managers/selectors/dimension-filters";
import { selectedDimensionValues } from "@rilldata/web-common/features/dashboards/state-managers/selectors/dimension-filters";
import {
createAndExpression,
createInExpression,
Expand All @@ -8,7 +8,6 @@ import {
} from "@rilldata/web-common/features/dashboards/stores/filter-utils";
import { createBatches } from "@rilldata/web-common/lib/arrayUtils";
import { type Readable, derived } from "svelte/store";

import { COMPARIONS_COLORS } from "@rilldata/web-common/features/dashboards/config";
import { getDimensionFilterWithSearch } from "@rilldata/web-common/features/dashboards/dimension-table/dimension-table-utils";
import {
Expand Down Expand Up @@ -99,20 +98,23 @@ export function getDimensionValuesForComparison(
// Values to be compared
let comparisonValues: (string | null)[] = [];
if (surface === "chart") {
const dimensionValues = includedDimensionValues({
dashboard: dashboardStore,
})(dimensionName);

if (dimensionValues?.length) {
// For TDD view max 11 allowed, for Explore max 7 allowed
comparisonValues = dimensionValues.slice(
0,
showTimeDimensionDetail ? 11 : 7,
) as (string | null)[];
}
return set({
values: comparisonValues,
filter: dashboardStore?.whereFilter,
return selectedDimensionValues(
runtime.instanceId,
[name],
dashboardStore?.whereFilter,
dimensionName,
).subscribe((values) => {
if (values.data?.length) {
// For TDD view max 11 allowed, for Explore max 7 allowed
comparisonValues = values.data.slice(
0,
showTimeDimensionDetail ? 11 : 7,
) as (string | null)[];
}
return set({
values: comparisonValues,
filter: dashboardStore?.whereFilter,
});
});
} else if (surface === "table") {
let sortBy = showTimeDimensionDetail
Expand Down
Loading