Draft
Conversation
Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-758
Prevents the dashboard preview from going blank during reconciliation when project files are edited externally.
Why this change?
Previously, when
validSpecbecame null during reconciliation, the frontend immediately reflected this, causing the dashboard preview to disappear. This change ensures a smoother user experience by retaining the last valid dashboard state until reconciliation completes.What was changed?
Implemented a cached selector (
createCachedExploreValidSpecSelector) that holds onto the last complete validexploreandmetricsViewspec. This cached spec is returned when the current response has a missingvalidSpecand resources are actively reconciling. Once reconciliation is idle, the cache is no longer used, allowing actual invalid states to surface. This selector was integrated intouseExploreValidSpecandgetExploreValidSpecQueryOptions.Checklist:
Linear Issue: APP-758