Cleanup orphaned managed git repos in deploy tests#8984
Open
Cleanup orphaned managed git repos in deploy tests#8984
Conversation
k-anshul
commented
Mar 6, 2026
| - Avoid short utility functions that are only used once; it is usually more readable to inline these in their parent function. | ||
| - Avoid variables that only serve as aliases unless there's a large readability improvement (i.e. the expression is very long and used several times); for example, instead of `db := table.Database`, just reference `table.Database` directly. | ||
| - Use the standard library `errors` (not `github.com/pkg/errors`). | ||
| - Prefer `require.NoError(...)` instead of `panic` in tests. |
Member
Author
There was a problem hiding this comment.
I often see it using panic in utility functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployments tests do not delete managed repos. The repos are currently deleted via a background worker only after an inactive period of 7 days.
Checklist: