Skip to content

fix clickhouse test#8988

Open
NamanMahor wants to merge 1 commit intomainfrom
fixing_clickhouse_test
Open

fix clickhouse test#8988
NamanMahor wants to merge 1 commit intomainfrom
fixing_clickhouse_test

Conversation

@NamanMahor
Copy link
Contributor

@NamanMahor NamanMahor commented Mar 6, 2026

fix clickhouse test

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

testMetricsViewTimeSeries_DayLightSavingsBackwards_Continuous_Daily(t, rt, instanceID)
})
t.Run("testMetricsViewTimeSeries_DayLightSavingsBackwards_Sparse_Daily", func(t *testing.T) { testMetricsViewTimeSeries_DayLightSavingsBackwards_Sparse_Daily(t, rt, instanceID) })
// t.Run("testMetricsViewTimeSeries_DayLightSavingsBackwards_Continuous_Second", func(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commenting it for clickhouse. looks like only for duckdb strange timezone behaviour mentioned here https://github.com/rilldata/rill/pull/8549/files#r2650861969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant