Conversation
Extract common row layout (icon + title + error tag + three-dot menu + subtitle) into a reusable `ResourceListRow` component. Alerts and reports composite cells now consume this shared component via props and slots. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove bordered cards, rounded corners, and background color from resource list items. Rows now use simple top/bottom divider lines matching the new design. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Alerts: Edit, Delete Reports: Run, Edit, Delete Updated ResourceListRow to use an actions slot instead of a hardcoded three-dot button, allowing each consumer to provide its own dropdown menu. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace `ResourceTypeBadge` (icon + label) with just the icon in dashboard rows. Keep raw AlertIcon/ReportIcon for alerts and reports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add pl-[22px] to dashboard subtitle to match icon + gap offset, consistent with alert and report rows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Edit navigates to the resource detail page - Delete calls the admin service mutation and refreshes the list - Run (reports only) triggers an ad-hoc report run - Code-created resources hide Edit/Delete (alerts hide entire menu) - Dropdown opens down-right (align="start") Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@Di7design the one thing missing in the design is the file name, not sure we want to remove it yet its still there ! |
|
Can we keep this icon tag in the front as well, it's easy to tell which is canvas which is Explore. @royendo |
|
so Badge and Label instead of just Badge, correct? |
- Alert/report table migration to ResourceListRow with dropdown actions - Delete confirmation dialogs for alerts and reports - ResourceListRow role fix - ResourceList deduplication (web-admin copy removed, imports point to web-common) - connector-metadata.ts → connector-icon-mapping.ts rename - ResourceList flat divider styling
- Migrate `ResourceListRow` to Svelte 5 ($props, snippets, Component type) - Extract shared `DeleteResourceConfirmDialog` replacing duplicate alert/report dialogs - Add `lastTrigger`/`lastRun` guard on error badge to avoid showing errors before first run - Add try/catch error handling to `handleDelete` and `handleRun` with user notifications - Migrate both `DashboardsTableCompositeCell` (web-admin + web-common) to use `ResourceListRow` - Hide dropdown menu entirely for code-created reports (matching alert pattern) - Document magic number `pl-[22px]` with comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Fix 2 — Svelte 5 migration:
Fix 3 — Shared delete dialog:
Fix 4 — lastTrigger guard:
Fix 5 — Error handling:
Fix 6 — Dashboards migrated to ResourceListRow:
Fix 7 — Hide dropdown for code-created reports:
Fix 9 — Magic number comment:
|
|
Oh those were existing but will fix in this PR! |
|
as discussed the color themeing extends past this PR and quite deeply into the first pass of dark mode, will take themes into a separate PR. |
|
Eric, no need to review this yet, im waiting for #9173 then will make sure the filter bar is available for these tables |




loom: https://www.loom.com/share/fd11546cd8c54ec59f4cd9371945560a
design: https://www.figma.com/design/JtG3sbaopjO0xQlyeCjmho/RILL-WIP?node-id=6857-271454&t=SrloSlXdGviOEwYN-4
Checklist: