Upgrade from uring-sys to uring-sys2 #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uring-sys appears to be not actively developed anymore. `uring-sys2` is a fork which still receives updates and fixes. In particular, it includes changes which make it build on musl-based systems. Unlike `uring-sys`, `uring-sys2` relies fully on bindgen. Thus, a few seemingly hand-written or altered declrations whch were included in the former are not availible (at least under the same name) in `uring-sys2`. In particular, `IoRingOp` is named `io_uring_op` in `uring-sys2`. The constant `LIBURING_UDATA_TIMEOUT` is gone seemingly without a replacement. We decided to at least produce the same value. Some fns used to accept `libc::msghdr`, but `uring-sys2` includes its own version, which unfortunately is a distinct type. We did compare the definitions and deemed the layout to be identical. Other than that, the mutability changed in a few places, but we still could preserve the existing `iou` interface.
... rather than reproducing the values using bitshifts directly. In addition, used this opportunity to add flags previously missing. The order of the definitions is ascending significance of the one bit set. It's the same order used previously and in the io_uring_setup(2) man page.
... rather than reproducing the values using bitshifts directly. In addition, used this opportunity to add features previously missing. The order of the definitions is ascending significance of the one bit set. It's the same order used previously and in the io_uring_setup(2) man page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time,
uring-sysdid not receive any updates in three and a half years. Open PRs seemingly never got merged, including one PR supplying a fix enablinguring-sysbeing built on musl-systems. For now, we have to assume it's abandoned.Luckily, a drop-in replacement which still receives updates and fixes exists in the form of
uring-sys2, a fork ofuring-sys. This PR switches over touring-sys2. In addition, it addsSetupFlagsandSetupFeaturesconstants which were introduced with newer versions ofliburing.