Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(WAT-647): Integration the sonarcloud to Enhance TestRing Automated Code Analysis Workflow #70

Merged
merged 3 commits into from
Jun 20, 2019
Merged

ci(WAT-647): Integration the sonarcloud to Enhance TestRing Automated Code Analysis Workflow #70

merged 3 commits into from
Jun 20, 2019

Conversation

danbao
Copy link
Collaborator

@danbao danbao commented Jun 20, 2019

No description provided.

@danbao danbao added the enhancement New feature or request label Jun 20, 2019
@danbao danbao self-assigned this Jun 20, 2019
@coveralls
Copy link

coveralls commented Jun 20, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1110

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.3%) to 80.086%
Files with Coverage Reduction New Missed Lines %
packages/cli-config/src/arguments-parser.ts 1 96.0%
packages/transport/src/serialize/function.ts 1 84.62%
packages/cli-config/src/config-file-reader.ts 1 90.0%
packages/utils/src/plugin-require.ts 1 80.0%
packages/utils/src/find-available-ports.ts 1 87.5%
packages/child-process/src/resolve-binary.ts 4 52.38%
packages/logger/src/format-log.ts 6 46.88%
packages/child-process/src/fork.ts 7 66.67%
Totals Coverage Status
Change from base Build 1091: 0.3%
Covered Lines: 1587
Relevant Lines: 1953
💛 - Coveralls

@danbao
Copy link
Collaborator Author

danbao commented Jun 20, 2019

ignore sonar-runner because travis-ci/travis-ci#10062
works on WAT-647 branch https://travis-ci.org/ringcentral/testring/jobs/548212754
here is demo https://sonarcloud.io/dashboard?branch=WAT-647&id=ringcentral_testring

@flops flops merged commit 1160c58 into master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flops flops flops approved these changes

Assignees

@danbao danbao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danbao @coveralls @flops