Add offchain-subnames application #83

wuminzhe · 2024-09-19T05:16:58Z

No description provided.

hackfisher

Thank you for applying for the grant, which is also related to the RFP: #61

To summarise from the communication meeting, the sponsorship amount will be approximately 2K USD, with a potential increase to 2.5K USD if the committee deems the deliverables to be outstanding.

To align with the budget, I suggest introducing @hujw77 to help the scope of Milestone 1, focusing on solution/contracts R&D and deployment.

Milestone 2 can remain dedicated to the gateway and UX, which must be open source.

We propose removing the milestone 3 for the admin UI, as we anticipate no need for daily operations. Any parameter adjustments can likely be managed via RingDAO proposals.

Additionally, please clarify how an anti-spam mechanism will be implemented.

wuminzhe · 2024-09-23T05:47:31Z

updated, pls review again. @hackfisher @hujw77

hujw77 · 2024-09-23T07:24:22Z

Can we just use the ens framework to do this? The advantage of this is that there is only one ens service maintained within the RingDAO ecosystem.

wuminzhe · 2024-10-04T10:24:45Z

based on deployed contracts by @hujw77, there are 2 parts needed to be implemented, the frontend ui and the gateway. Here are some questions to discuss on how to get them work together.

for frontend ui.
1. a product design. especially on fee and renew/extend pages
2. contract functions.
  1. Register function
  2. getFee function
  3. Address to subname function
for gateway.
1. contract functions.
  1. subname to address function

wuminzhe · 2024-10-10T04:46:32Z

do you have any other requirements? when and how to renew/extend?
define the fee structure.
define the subname rules.

wuminzhe · 2024-10-10T05:02:42Z

@hackfisher @hujw77 pls check these questions and the basic design. if needed, we can schedule a meeting for this. cc @nblogist

nblogist · 2024-10-10T11:13:35Z

@hackfisher @hujw77 pls check these questions and the basic design. if needed, we can schedule a meeting for this. cc @nblogist

Looks straight forward - i go with the ringdao color palette - and i see we can be flexible with design according to standard ENS type stuff.

@wuminzhe can you list any other functionality you'd like on the UI - so i have an exhaustive list - in case the sketch above didn't capture something.

wuminzhe · 2024-10-11T07:49:48Z

src/L2/RegistrarController.sol

valid: check name length
available:
registerPrice:
renew:

wuminzhe · 2024-11-05T01:46:18Z

@hackfisher updated

hackfisher · 2024-11-05T04:07:35Z

https://github.com/orgs/darwinia-network/discussions/1564

hackfisher · 2024-11-05T04:10:59Z

https://github.com/orgs/darwinia-network/discussions/1406

hackfisher · 2024-11-05T09:18:44Z

@hackfisher updated

I see that Milestone 1 mainly covers your learning phase, which seems a bit light. For Milestone 2, it only supports the testnet and includes Sepolia, which is unrelated to Darwinia. I hope Milestone 2 can support the Darwinia mainnet and go live (accessible to users), while also introducing more gateway details and supplementing any contract work from Echo by Itering (if available).

Is the gateway’s task to query domain records from the RegistrarController on Darwinia, with a signer responsible for signing once the CCIP Resolver matches successfully?

Based on my understanding, the Gateway’s source code and the domain solver can both be replaceable, correct?

Note: This needs to be a public good (open source) for Darwinia and Darwinia-related projects.

hackfisher · 2024-11-05T09:29:00Z

grant/projects/offchain-subnames.md

+- https://github.com/wuminzhe/basenames
+  The repo for the basenames contracts.
+
+- https://github.com/wuminzhe/offchain-resolver  
+  The repo provides the offchain resolve client.
+
+- https://github.com/wuminzhe/subnames-ui
+  The repo for the UI.
+
+- https://github.com/wuminzhe/subnames-gateway
+  The repo for the offchain gateway.


These seems not open source. It's OK for now, but open source and license need to be committed in delivery of each milestones.

https://github.com/wuminzhe/offchain-resolver

https://github.com/wuminzhe/subnames-gateway
@wuminzhe Do these two repos do the same thing, and can they be merged?

yes, I will opensource all

Hi, please add the open source commitment in your tasks/deliveries in the application.

wuminzhe · 2024-11-05T09:37:12Z

I see that Milestone 1 mainly covers your learning phase, which seems a bit light.

Milestone 1 is not only for learning, but also for the contracts detail and align it with ringdao's reqirements.

For Milestone 2, it only supports the testnet and includes Sepolia, which is unrelated to Darwinia. I hope Milestone 2 can support the Darwinia mainnet and go live (accessible to users),

Milestone 2 includes the step of production deployment.
testnet is Darwinia Koi network.

while also introducing more gateway details and supplementing any contract work from Echo by Itering (if available).

The Gateway is an ERC-3668 implemetion. so, I think the spec is a better place to show the detail. For coding detail, I will provide a guide with the code.

I will add echo's task.

Is the gateway’s task to query domain records from the RegistrarController on Darwinia, with a signer responsible for signing once the CCIP Resolver matches successfully?

Yes, absolutely correct.

Based on my understanding, the Gateway’s source code and the domain solver can both be replaceable, correct?

Yes, gateway is a offchain service. you can update the url in L1Resolver to replace it. Even the L1Resolver itself can be replaced with a new one.

hujw77 · 2024-11-05T09:40:03Z

https://github.com/ringecosystem/basenames/blob/main/ADDR.md
Can we use this repo‘s contract addresses for testing, so that I can fix it if there are any problems?

wuminzhe · 2024-11-05T09:53:07Z

https://github.com/ringecosystem/basenames/blob/main/ADDR.md Can we use this repo‘s contract addresses for testing, so that I can fix it if there are any problems?

I made my own fork to play with it and play the foundry framework. And I have deployed contracts to Darwinia Koi with sepolia.

Here is the latest UI working with the contracts
https://subnames-ui.vercel.app/

hackfisher · 2024-11-06T02:53:54Z

grant/projects/offchain-subnames.md

+    2. Deploy to testnet(Darwinia Koi).
+4. Production deployment
+
+### Additional Information


Suggested change

### Additional Information

### Additional Information

Please note that this grant includes contract and solution contributions from Itering. As Itering’s work is provided separately as a Service Provider to RingDAO, compensation for these efforts is not included in the grant amount. The full grant reward will be allocated to Aki for fulfilling the grant scope, with Itering offering the necessary support.

hackfisher · 2024-11-06T02:58:30Z

grant/projects/offchain-subnames.md

+1. Contracts
+   1. Pre research.  
+      Echo did and will continue the research.   
+      Aki registered a real basename([akiwu.base.eth](https://www.base.org/name/akiwu)) on the https://www.base.org/names to verify the operations logic.
+   2. Fork basenames repo and update the contracts to align with Darwinia Chain.
+   3. Deploy to testnet(Dariwnia Koi).
+2. Gateway  
+   1. Implement the EIP-3668 offchain gateway.
+   2. Deployment.
+3. UI
+    1. Implement logic for
+       1. wallet connect including customizing it to support subname.
+       2. register including reverse register and fee calculation
+       3. renew
+    2. Deploy to testnet(Darwinia Koi).
+4. Production deployment
+


Please refine the Production Development section, clarifying that it will be deployed on the Darwinia chain, and list the key deliverables in detail:

1. Scope of the open-source code repository, including its license. 2. Documentation and testing (if available). 3. Pricing plan, including the arrangement and distribution of revenue.

yes, I will update them.

Add offchain-subnames application

b09f8c9

wuminzhe requested review from hackfisher, hujw77 and boundless-forest and removed request for boundless-forest September 19, 2024 05:17

wuminzhe added 11 commits September 19, 2024 13:24

update

931201e

update

00312ac

update

212c4b2

update

e0aa13c

update

169b80f

update

e9da36a

update to ringdao.eth

1db606a

update

4036ae2

update

f721ae8

update

be46411

update

95686a9

hackfisher requested changes Sep 21, 2024

View reviewed changes

update

249d8aa

update

9b4f772

hackfisher reviewed Nov 5, 2024

View reviewed changes

update

e6e19f0

hackfisher requested changes Nov 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add offchain-subnames application #83

Add offchain-subnames application #83

wuminzhe commented Sep 19, 2024

hackfisher left a comment

wuminzhe commented Sep 23, 2024

hujw77 commented Sep 23, 2024 •

edited

Loading

wuminzhe commented Oct 4, 2024 •

edited

Loading

wuminzhe commented Oct 10, 2024 •

edited

Loading

wuminzhe commented Oct 10, 2024

nblogist commented Oct 10, 2024

wuminzhe commented Oct 11, 2024

wuminzhe commented Nov 5, 2024

hackfisher commented Nov 5, 2024

hackfisher commented Nov 5, 2024

hackfisher commented Nov 5, 2024

hackfisher Nov 5, 2024

hujw77 Nov 5, 2024

wuminzhe Nov 5, 2024

hackfisher Nov 6, 2024

wuminzhe commented Nov 5, 2024

hujw77 commented Nov 5, 2024

wuminzhe commented Nov 5, 2024 •

edited

Loading

hackfisher Nov 6, 2024

hackfisher Nov 6, 2024

wuminzhe Nov 6, 2024

Add offchain-subnames application #83

Are you sure you want to change the base?

Add offchain-subnames application #83

Conversation

wuminzhe commented Sep 19, 2024

hackfisher left a comment

Choose a reason for hiding this comment

wuminzhe commented Sep 23, 2024

hujw77 commented Sep 23, 2024 • edited Loading

wuminzhe commented Oct 4, 2024 • edited Loading

wuminzhe commented Oct 10, 2024 • edited Loading

wuminzhe commented Oct 10, 2024

nblogist commented Oct 10, 2024

wuminzhe commented Oct 11, 2024

wuminzhe commented Nov 5, 2024

hackfisher commented Nov 5, 2024

hackfisher commented Nov 5, 2024

hackfisher commented Nov 5, 2024

hackfisher Nov 5, 2024

Choose a reason for hiding this comment

hujw77 Nov 5, 2024

Choose a reason for hiding this comment

wuminzhe Nov 5, 2024

Choose a reason for hiding this comment

hackfisher Nov 6, 2024

Choose a reason for hiding this comment

wuminzhe commented Nov 5, 2024

hujw77 commented Nov 5, 2024

wuminzhe commented Nov 5, 2024 • edited Loading

hackfisher Nov 6, 2024

Choose a reason for hiding this comment

hackfisher Nov 6, 2024

Choose a reason for hiding this comment

wuminzhe Nov 6, 2024

Choose a reason for hiding this comment

hujw77 commented Sep 23, 2024 •

edited

Loading

wuminzhe commented Oct 4, 2024 •

edited

Loading

wuminzhe commented Oct 10, 2024 •

edited

Loading

wuminzhe commented Nov 5, 2024 •

edited

Loading