Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Design and Flow changes #40

Merged
merged 41 commits into from
Sep 2, 2024
Merged

New Design and Flow changes #40

merged 41 commits into from
Sep 2, 2024

Conversation

nblogist
Copy link
Collaborator

@nblogist nblogist commented Aug 7, 2024

Introduces new design and flow changes.

@hamidroohi71
Copy link
Collaborator

hamidroohi71 commented Aug 8, 2024

I am working to fix all the following contents:

  • Add new design UI components
  • Fix design for mobile
  • Add interactivity to the UI elements
  • Fix remaining items from the UI design
  • Fix the design for wallet connection modal
  • Fix the wallet connection process
  • Fix the wallet data reading in the header and transfer inputs
  • Fix the token mapping between the sender and recipient
  • Fix the input address logic for both sender and recipient
  • Fix modals reading data
  • Fix final transaction step
  • Fix the chain and wallet switch when selected chain changed
  • Change the chain selection in the way match tokens
  • Add Motions
  • Handle wallet address change in sender input
  • Control the styles and functionality in mobile and tablet
  • Review the code for possible bugs
  • Remove the unused components

@nblogist nblogist marked this pull request as draft August 8, 2024 01:25
@nblogist
Copy link
Collaborator Author

nblogist commented Aug 8, 2024

Will let Fnunkuy check out the issue with deployment. so vivian can get a vercel link to view.

@hackfisher
Copy link
Contributor

Will let Fnunkuy check out the issue with deployment. so vivian can get a vercel link to view.

@fewensa Would you please help diagnostic the cause for the failure of deployment?

Copy link

github-actions bot commented Aug 8, 2024

---
Commit: 7cfdac6
Preview: https://crosschain-3w1pxquvl-itering.vercel.app https://paralink-dev.vercel.app

---
Commit: 172e2d2
Preview: https://crosschain-levin27uw-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 407cba8
Preview: https://crosschain-pbn28aax5-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 272e50c
Preview: https://crosschain-i0lsrcq6j-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 58b193e
Preview: https://crosschain-8qu3jy4mm-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: f70f711
Preview: https://crosschain-coqtiu6bj-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: a384395
Preview: https://crosschain-k9ax734dj-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 6878667
Preview: https://crosschain-htdx1aiev-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 29ce510
Preview: https://crosschain-m1d4k5aae-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: e5ecb4a
Preview: https://crosschain-7ukmzgcti-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 563e398
Preview: https://crosschain-i8prq97xo-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 1d2b9d9
Preview: https://crosschain-kybi8edrs-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 8ae81e9
Preview: https://crosschain-hdl5ucjet-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: b0512c6
Preview: https://crosschain-355n83itq-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: d88a489
Preview: https://crosschain-i41974a2f-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 0ed0772
Preview: https://crosschain-q93bwi1vn-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: d4127cd
Preview: https://crosschain-jtnjku4t2-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 5e02603
Preview: https://crosschain-l9cithmgp-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 2ca1e0c
Preview: https://crosschain-i5vpn8frr-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 55751f6
Preview: https://crosschain-eaxwr6an8-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 5dcfbdc
Preview: https://crosschain-91prjn1o0-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: e290368
Preview: https://crosschain-m9uhxd1ev-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 5c1daba
Preview: https://crosschain-1r6g3zqqq-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 6ed8755
Preview: https://crosschain-h2dty6kmf-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: fbd45a5
Preview: https://crosschain-76kzqs7rc-itering.vercel.app https://paralink-dev.vercel.app
---
Commit: 38d65d5
Preview: https://crosschain-8owy86hsh-itering.vercel.app https://paralink-dev.vercel.app

@nblogist nblogist marked this pull request as ready for review August 26, 2024 07:03
@nblogist
Copy link
Collaborator Author

Hey guys this is more or less ready - we are running some tests and fine tuning some edges this week but we can start taking a look at this.

@hackfisher
Copy link
Contributor

@1022ranji and @boundless-forest Please help test and feedback.

@DreUncle
Copy link

https://www.figma.com/design/OseMkyZivJbottjf6GcXlr/APPS?node-id=16035-4054&t=dPgrar76iAPAZ2Qv-0
I have made a unified process, please use the chain&token logo here to replace the existing one

@hackfisher
Copy link
Contributor

@1022ranji I'am not sure if the supported wallets to connect is in the scope of this improvement.

But following wallets and wallet connect are definitely to be supported:

image image

Reference:

https://apps.moonbeam.network/moonbeam/xcm?asset=dot

@1022ranji
Copy link

1022ranji commented Aug 27, 2024

ParaLink Test & Feedback @nblogist @hamidroohi71

Test version: https://crosschain-l9cithmgp-itering.vercel.app/

  • Can not read my balance
image
  • Spell wrong (you --> your)
image
  • There is an inconsistency in the capitalization style used in the prompt messages on the page. Please update to:

Please connect to your wallet
Please enter the recipient address
Please enter the amount

image
  • The address “Copy” button doesn’t work
image image

@nblogist
Copy link
Collaborator Author

Thank you for your feedback @1022ranji ! Interesting to see that it isn't showing your balance - but it is for me
image

CC @hamidroohi71

Looking into rest of the parts!

@nblogist
Copy link
Collaborator Author

nblogist commented Aug 29, 2024

image

  • Drop down is hiding

image

  • Is this supposed to be animated?

image

  • Details link isn't clickable

I don't see ring show up here but that might take some time - so wil check again in a few mins

image

@1022ranji
Copy link

@nblogist Could we aim to finalize this pull request by the end of this week and release a new version? That way, we can make progress on the RingDAO Vote issue ringecosystem/vote.ringdao.com#4.

@hackfisher
Copy link
Contributor

@nblogist Could we aim to finalize this pull request by the end of this week and release a new version? That way, we can make progress on the RingDAO Vote issue darwinia-network/vote.ringdao.com#4.

If there are difficulties, we can first release a viable and functional version, and address the remaining issues later.

@hamidroohi71
Copy link
Collaborator

@nblogist Could we aim to finalize this pull request by the end of this week and release a new version? That way, we can make progress on the RingDAO Vote issue darwinia-network/vote.ringdao.com#4.

If there are difficulties, we can first release a viable and functional version, and address the remaining issues later.

Hi. Actually, we were done at the end of last week. But adding the new wallets according to Raji's comment make us in a way to put much more effort into implementing 9 new wallets with app. It's the reason of why it's taking longer again.

@hamidroohi71
Copy link
Collaborator

If you want I can finalize it without this feature and release it and then after doing other tasks, I willl work on new wallet design and implementations.

@hackfisher
Copy link
Contributor

If you want I can finalize it without this feature and release it and then after doing other tasks, I willl work on new wallet design and implementations.

LGTM

@1022ranji
Copy link

If you want I can finalize it without this feature and release it and then after doing other tasks, I willl work on new wallet design and implementations.

LGTM

@nblogist @hamidroohi71 All features are functioning now except for the wallet. I suggest we finalize and release this version first, and then address the remaining wallet issues after completing ringecosystem/vote.ringdao.com#4.

@hackfisher hackfisher merged commit f7799e8 into main Sep 2, 2024
1 check passed
@hackfisher hackfisher deleted the hidotmatrix/fix/newDesign branch September 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants