Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paid events #25

Merged
merged 7 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,5 @@ Example/Pods

fastlane/*
!fastlane/.env
tests-build/*
test-reports/*
2 changes: 2 additions & 0 deletions Changelogs/1.5.0
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ Improvements to the 'RingPublishingTracking' module.
* Separate method to update user data
* Separate method to update SSO system name
* New method for user logout
* New event parameter - Content marked as paid
* New tracking event types for paid
82 changes: 65 additions & 17 deletions Example/RingPublishingTracking.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@ final class ClientDecorator: Decorator {
var parameters: [String: AnyHashable] {
var userDataParams: [String: AnyHashable] = [:]

// swiftlint:disable non_optional_string_data_conversion
if let jsonData = try? JSONEncoder().encode(client),
let jsonString = String(data: jsonData, encoding: .utf8) {
userDataParams["RDLC"] = Data(jsonString.utf8).base64EncodedString()
}
// swiftlint:enable non_optional_string_data_conversion
userDataParams["RDLC"] = client.jsonStringBase64

return userDataParams
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ struct ContentMarkAsPaid: Encodable {
case source
}

init(contentMetadata: ContentMetadata) {
init?(contentMetadata: ContentMetadata?) {
guard let contentMetadata = contentMetadata else {
return nil
}

publication = Publication(premium: contentMetadata.paidContent)
source = Source(id: contentMetadata.contentId, system: contentMetadata.sourceSystemName)
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//
// PaidEventUserId.swift
// RingPublishingTracking
//
// Created by Bernard Bijoch on 04/09/2024.
//

import Foundation

struct PaidEventUserId: Encodable {

enum CodingKeys: String, CodingKey {
case fakeUserId = "fake_user_id"
case realUserId = "real_user_id"
}

let fakeUserId: String?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ma tylko sens jak są dwie wartości

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamszeremeta ten obiekt wykorzystywany jest tez przy createPurchaseEvent, gdzie idzie tylko fake_user_id

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ale tam ma Bernard to podane jawnie jako
temporaryUserId: String?

bo potem to nie wymusza w tym zdarzeniu z przepisaniem usera podania dwoch wartosci.. chyba ze przez konstruktor to wymusimy a zostanie do uzytku wewnetrznego opcjonalne to ok

let realUserId: String?
}
175 changes: 175 additions & 0 deletions Sources/RingPublishingTracking/Private/EventsFactory+Paid.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@
//
// EventsFactory+Paid.swift
// RingPublishingTracking
//
// Created by Bernard Bijoch on 04/09/2024.
//

import Foundation

extension EventsFactory {

func createPaidEvent(parameters: [String: AnyHashable]) -> Event {
return Event(analyticsSystemName: AnalyticsSystem.kropkaEvents.rawValue,
eventName: EventType.paid.rawValue,
eventParameters: parameters)
}

func createShowOfferEvent(contentMetadata: ContentMetadata?,
offerData: OfferData,
offerContextData: OfferContextData,
targetPromotionCampaignCode: String?) -> Event {
var parameters: [PaidEventParameter: AnyHashable] = [:]

parameters[.eventCategory] = "checkout"
parameters[.eventAction] = "showOffer"
parameters[.supplierAppId] = offerData.supplierData.supplierAppId
parameters[.paywallSupplier] = offerData.supplierData.paywallSupplier
parameters[.paywallTemplateId] = offerData.paywallTemplateId
parameters[.displayMode] = offerData.displayMode.rawValue
parameters[.source] = offerContextData.source
parameters[.sourceDx] = contentMetadata?.dxParameter
parameters[.sourcePublicationUuid] = contentMetadata?.publicationId
parameters[.paywallVariantId] = offerData.paywallVariantId
parameters[.closurePercentage] = offerContextData.closurePercentage
parameters[.tpcc] = targetPromotionCampaignCode
parameters[.contentMarkedAsPaid] = contentMetadata?.rdlcnParameter

return createPaidEvent(parameters: parameters.keysAsStrings)
}

func createShowOfferTeaserEvent(contentMetadata: ContentMetadata?,
offerData: OfferData,
offerContextData: OfferContextData,
targetPromotionCampaignCode: String?) -> Event {
var parameters: [PaidEventParameter: AnyHashable] = [:]

parameters[.eventCategory] = "checkout"
parameters[.eventAction] = "showOfferTeaser"
parameters[.supplierAppId] = offerData.supplierData.supplierAppId
parameters[.paywallSupplier] = offerData.supplierData.paywallSupplier
parameters[.paywallTemplateId] = offerData.paywallTemplateId
parameters[.displayMode] = offerData.displayMode.rawValue
parameters[.source] = offerContextData.source
parameters[.sourceDx] = contentMetadata?.dxParameter
parameters[.sourcePublicationUuid] = contentMetadata?.publicationId
parameters[.paywallVariantId] = offerData.paywallVariantId
parameters[.closurePercentage] = offerContextData.closurePercentage
parameters[.tpcc] = targetPromotionCampaignCode
parameters[.contentMarkedAsPaid] = contentMetadata?.rdlcnParameter

return createPaidEvent(parameters: parameters.keysAsStrings)
}

func createPurchaseClickButtonEvent(contentMetadata: ContentMetadata?,
offerData: OfferData,
offerContextData: OfferContextData,
termId: String,
targetPromotionCampaignCode: String?) -> Event {
var parameters: [PaidEventParameter: AnyHashable] = [:]

parameters[.eventCategory] = "checkout"
parameters[.eventAction] = "clickButton"
parameters[.supplierAppId] = offerData.supplierData.supplierAppId
parameters[.paywallSupplier] = offerData.supplierData.paywallSupplier
parameters[.paywallTemplateId] = offerData.paywallTemplateId
parameters[.displayMode] = offerData.displayMode.rawValue
parameters[.source] = offerContextData.source
parameters[.termId] = termId
parameters[.sourceDx] = contentMetadata?.dxParameter
parameters[.sourcePublicationUuid] = contentMetadata?.publicationId
parameters[.paywallVariantId] = offerData.paywallVariantId
parameters[.tpcc] = targetPromotionCampaignCode
parameters[.contentMarkedAsPaid] = contentMetadata?.rdlcnParameter

return createPaidEvent(parameters: parameters.keysAsStrings)
}

// swiftlint:disable function_parameter_count

func createPurchaseEvent(contentMetadata: ContentMetadata?,
offerData: OfferData,
offerContextData: OfferContextData,
subscriptionPaymentData: SubscriptionPaymentData,
termId: String,
termConversionId: String,
targetPromotionCampaignCode: String?,
temporaryUserId: String?) -> Event {
var parameters: [PaidEventParameter: AnyHashable] = [:]

parameters[.eventCategory] = "checkout"
parameters[.eventAction] = "purchase"
parameters[.supplierAppId] = offerData.supplierData.supplierAppId
parameters[.paywallSupplier] = offerData.supplierData.paywallSupplier
parameters[.paywallTemplateId] = offerData.paywallTemplateId
parameters[.displayMode] = offerData.displayMode.rawValue
parameters[.source] = offerContextData.source
parameters[.termId] = termId
parameters[.termConversionId] = termConversionId
parameters[.paymentMethod] = subscriptionPaymentData.paymentMethod.rawValue
parameters[.subscriptionBasePrice] = subscriptionPaymentData.subscriptionBasePrice
parameters[.subscriptionPriceCurrency] = subscriptionPaymentData.subscriptionPriceCurrency
parameters[.sourceDx] = contentMetadata?.dxParameter
parameters[.sourcePublicationUuid] = contentMetadata?.publicationId
parameters[.paywallVariantId] = offerData.paywallVariantId
parameters[.tpcc] = targetPromotionCampaignCode
parameters[.subscriptionPromoPrice] = subscriptionPaymentData.subscriptionPromoPrice
parameters[.subscriptionPromoPriceDuration] = subscriptionPaymentData.subscriptionPromoPriceDuration
parameters[.eventDetails] = PaidEventUserId(fakeUserId: temporaryUserId, realUserId: nil).jsonString
parameters[.contentMarkedAsPaid] = contentMetadata?.rdlcnParameter

return createPaidEvent(parameters: parameters.keysAsStrings)
}

// swiftlint:enable function_parameter_count

func createShowMetricLimitEvent(contentMetadata: ContentMetadata?,
supplierData: SupplierData,
metricsData: MetricsData) -> Event {
var parameters: [PaidEventParameter: AnyHashable] = [:]

parameters[.eventCategory] = "metric_limit"
parameters[.eventAction] = "showMetricLimit"
parameters[.supplierAppId] = supplierData.supplierAppId
parameters[.paywallSupplier] = supplierData.paywallSupplier
parameters[.metricLimitName] = metricsData.metricLimitName
parameters[.freePvCnt] = metricsData.freePageViewCount
parameters[.freePvLimit] = metricsData.freePageViewLimit
parameters[.sourceDx] = contentMetadata?.dxParameter
parameters[.sourcePublicationUuid] = contentMetadata?.publicationId
parameters[.contentMarkedAsPaid] = contentMetadata?.rdlcnParameter

return createPaidEvent(parameters: parameters.keysAsStrings)
}

func createLikelihoodScoringEvent(contentMetadata: ContentMetadata?,
supplierData: SupplierData,
likelihoodData: LikelihoodData) -> Event {
var parameters: [PaidEventParameter: AnyHashable] = [:]

parameters[.eventCategory] = "likelihood_scoring"
parameters[.eventAction] = "likelihoodScoring"
parameters[.supplierAppId] = supplierData.supplierAppId
parameters[.paywallSupplier] = supplierData.paywallSupplier
parameters[.sourceDx] = contentMetadata?.dxParameter
parameters[.sourcePublicationUuid] = contentMetadata?.publicationId
parameters[.eventDetails] = likelihoodData.jsonString
parameters[.contentMarkedAsPaid] = contentMetadata?.rdlcnParameter

return createPaidEvent(parameters: parameters.keysAsStrings)
}

func createMobileAppFakeUserIdReplacedEvent(contentMetadata: ContentMetadata?,
temporaryUserId: String,
realUserId: String) -> Event {
var parameters: [PaidEventParameter: AnyHashable] = [:]

parameters[.eventCategory] = "mobile_app_fake_user_id_replaced"
parameters[.eventAction] = "mobileAppFakeUserIdReplaced"
parameters[.eventDetails] = PaidEventUserId(fakeUserId: temporaryUserId, realUserId: realUserId).jsonString
parameters[.contentMarkedAsPaid] = ContentMarkAsPaid(contentMetadata: contentMetadata)?.jsonStringBase64

return createPaidEvent(parameters: parameters.keysAsStrings)
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,7 @@ extension ContentMetadata {
return "PV_4,\(sourceSystem),\(pubId),\(part),\(paid)".replacingOccurrences(of: " ", with: "_")
}

// swiftlint:disable non_optional_string_data_conversion

var rdlcnParameter: String? {
let contentMarkAsPaid = ContentMarkAsPaid(contentMetadata: self)

if let jsonData = try? Self.encoder.encode(contentMarkAsPaid),
let jsonString = String(data: jsonData, encoding: .utf8) {
return Data(jsonString.utf8).base64EncodedString()
}

return nil
return ContentMarkAsPaid(contentMetadata: self).jsonStringBase64
}

// swiftlint:enable non_optional_string_data_conversion

}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
//
// Encodable+JSON.swift
// RingPublishingTracking
//
// Created by Bernard Bijoch on 04/09/2024.
//

import Foundation

extension Encodable {

// swiftlint:disable non_optional_string_data_conversion

var jsonString: String? {
let encoder = JSONEncoder()
encoder.outputFormatting = .sortedKeys

guard let data = try? encoder.encode(self),
let jsonString = String(data: data, encoding: .utf8) else { return nil }

return jsonString
}

// swiftlint:enable non_optional_string_data_conversion

var jsonStringBase64: String? {
guard let jsonString = jsonString else { return nil }

return Data(jsonString.utf8).base64EncodedString()
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,7 @@ extension VideoVisibility {

let visibilityData = VideoVisibilityWrapper(context: VideoVisibilityContext(visible: visibilityParamName))

// swiftlint:disable non_optional_string_data_conversion
guard let jsonData = try? JSONEncoder().encode(visibilityData),
let jsonString = String(data: jsonData, encoding: .utf8) else {
return nil
}
// swiftlint:enable non_optional_string_data_conversion

return Data(jsonString.utf8).base64EncodedString()
return visibilityData.jsonStringBase64
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ enum EventType: String {
case keepAlive = "KeepAlive"
case videoEvent = "VidEvent"
case error = "ErrEvent"
case paid = "PaidEvent"
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ final class KeepAliveManager {
private var pauseTimeStart = [Date]()
private var pauseTimeEnd = [Date]()

private let timerQueue = DispatchQueue(label: "timerQueue", attributes: .concurrent)
Copy link
Contributor Author

@bbijoch bbijoch Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To jest fix na testy które na fastlanie nie przechodziły. Timery były uruchamiane z qos: .background. Teraz zrobiłem dedykowaną kolejkę .concurrent
U mnie lokalnie testy na fastlane też nie przechodziły, a teraz już przechodzą

private var measurementTimer: DispatchSourceTimer?
private var sendingTimer: DispatchSourceTimer?

Expand Down Expand Up @@ -213,6 +214,25 @@ extension KeepAliveManager {

extension KeepAliveManager {

/// Schedule timer on dedicated concurrent queue
/// Action is called on main thread
///
/// - Parameters:
/// - timeInterval: TimeInterval from now when timer should fire
/// - action: (() -> Void)? Action to execute when timer is fired
func scheduledTimer(timeInterval: TimeInterval, action: (() -> Void)?) -> DispatchSourceTimer {
let timer = DispatchSource.makeTimerSource(queue: timerQueue)
timer.setEventHandler {
DispatchQueue.main.async {
action?()
}
}
timer.schedule(deadline: .now() + timeInterval, repeating: .never)
timer.activate()

return timer
}

private func scheduleMeasurementTimer() {
guard let timeFromStart = timeFromStart else {
stop()
Expand All @@ -223,7 +243,7 @@ extension KeepAliveManager {

Logger.log("Keep alive manager: Scheduling measurement timer \(interval)s")

measurementTimer = DispatchQueue.scheduledTimer(timeInterval: interval, action: { [weak self] in
measurementTimer = scheduledTimer(timeInterval: interval, action: { [weak self] in
self?.takeMeasurements(measureType: .activityTimer)
self?.scheduleMeasurementTimer()
})
Expand All @@ -239,7 +259,7 @@ extension KeepAliveManager {

Logger.log("Keep alive manager: Scheduling sending timer \(interval)s")

sendingTimer = DispatchQueue.scheduledTimer(timeInterval: interval, action: { [weak self] in
sendingTimer = scheduledTimer(timeInterval: interval, action: { [weak self] in
self?.takeMeasurements(measureType: .sendTimer)
self?.sendMeasurements()
self?.scheduleSendingTimer()
Expand Down
Loading