Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Add cifuzz integration #1028

Merged
merged 1 commit into from
May 2, 2024
Merged

fuzz: Add cifuzz integration #1028

merged 1 commit into from
May 2, 2024

Conversation

manunio
Copy link
Contributor

@manunio manunio commented May 1, 2024

Add cifuzz workflow action to have fuzzers build and run on each PR.
This is a service offered by oss-fuzz where askama already runs. cifuzz can help catch shallow bugs, regressions and fuzzing build issues before they are merged into the repository, to do this fuzzing will be run for ~5min.

@djc
Copy link
Collaborator

djc commented May 2, 2024

Thanks! 5 minutes feels kind of long when the complete CI workflow right now completes in 3.5. Can we make it like 3 minutes, or do we lose a lot of that to setup stuff?

Add cifuzz workflow action to have fuzzers build and run on each
PR. This is a service offered by oss-fuzz where askama already runs.
cifuzz can help catch shallow bugs, regressions and fuzzing build
issues before they are merged into the repository, to do this
fuzzing will be run for ~3min.
@manunio manunio force-pushed the feat-add-cifuzz branch from 848d1d1 to e3317c0 Compare May 2, 2024 20:52
@manunio
Copy link
Contributor Author

manunio commented May 2, 2024

Thanks! 5 minutes feels kind of long when the complete CI workflow right now completes in 3.5. Can we make it like 3 minutes, or do we lose a lot of that to setup stuff?

I think 3 minutes is fine for now, as setup time is not inclusive of fuzzing seconds, it will most probably take somewhere around 3 to 4 mins for each run.

@djc djc merged commit 2699ba4 into rinja-rs:main May 2, 2024
17 checks passed
@manunio manunio deleted the feat-add-cifuzz branch May 2, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants