Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve macro call arguments mismatch errors #325

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

GuillaumeGomez
Copy link
Contributor

Fixes #323.

@Kijewski
Copy link
Collaborator

Could you please add two tests in macro_named_argument.rs:

  • 2 non-default arguments, no arguments provided in {% call %}
  • 1 non-default, 1 default argument, no arguments provided in {% call %}

@GuillaumeGomez
Copy link
Contributor Author

Sure, done!

@Kijewski
Copy link
Collaborator

Kijewski commented Feb 1, 2025

I think sometimes the wrong argument name was printed. Can you please verify if my change gets it right?

@Kijewski
Copy link
Collaborator

Kijewski commented Feb 4, 2025

The PR needs rebasing, then the formatting error should be gone. I didn't do the rebase, so my change to your PR remains legible.

@GuillaumeGomez
Copy link
Contributor Author

Forgot to check, let me get back to it.

@GuillaumeGomez
Copy link
Contributor Author

Looks all good to me, thanks! I cannot approve my own PR though. 😅

@Kijewski Kijewski merged commit c130590 into rinja-rs:master Feb 4, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile error "macro expected at least N arguments..." is off by one.
2 participants