chore: Upgrade to Winnow 0.7 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not thrilled with the fact that annotations of some kind (I used no-op `map_err`s here) are needed for the errors and will be digging into this to better understand why. The code in `toml_edit` is very similar and yet it doesn't need them.
2 tasks
|
Nice thanks! @Kijewski Any idea what's going on with the failing CI? |
|
Looks like MicroSoft made DevSkim depend on a newer .net version, but they forgot to tell the script to install the newer version, too: microsoft/DevSkim-Action#30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not thrilled with the fact that annotations of some kind (I usedno-op
map_errs here) are needed for the errors and will be digginginto this to better understand why. The code in
toml_editis verysimilar and yet it doesn't need them.
Those
map_errs were needed to workaroundimpl From for ErrMode.ErrModeis now optional, so its unclear when calling a generic error if its returning aErrorContextor aErrMode<ErrorContext>. See winnow-rs/winnow#735