Add Token Search Results #1056
Merged
Add Token Search Results #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
reviewed
Oct 8, 2024
src/containers/shared/components/SearchResults/SearchResults.tsx
Outdated
Show resolved
Hide resolved
|
Make sure the search doesnt happen on non mainet explorers. The xrpl meta url should also be an environment variable. |
ckniffen
reviewed
Oct 8, 2024
src/containers/shared/components/SearchResults/SearchResults.tsx
Outdated
Show resolved
Hide resolved
pdp2121
reviewed
Oct 29, 2024
pdp2121
reviewed
Oct 29, 2024
pdp2121
reviewed
Oct 29, 2024
ckniffen
reviewed
Nov 6, 2024
src/containers/shared/components/TokenSearchResults/TokenSearchResults.tsx
Outdated
Show resolved
Hide resolved
ckniffen
requested changes
Nov 6, 2024
src/containers/shared/components/TokenSearchResults/styles.scss
Outdated
Show resolved
Hide resolved
| </div> | ||
| </div> | ||
| </div> | ||
| <div className="result-issuer-line"> |
There was a problem hiding this comment.
I meant the bottom two lines
src/containers/shared/components/TokenSearchResults/TokenSearchResults.tsx
Show resolved
Hide resolved
ckniffen
approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
| @@ -540,6 +540,9 @@ | |||
| "asset_class": "Asset Class", | |||
| "trading_pairs": "Trading Pairs", | |||
| "deleted": "Deleted", | |||
| "holders": "HOLDERS: {{holders}}", | |||
| "trustlines": " TRUSTLINES: {{trustlines}}", | |||
| "website": "Wesbite", | |||
10 tasks
mvadari
pushed a commit
that referenced
this pull request
Dec 18, 2024
## High Level Overview of Change Fix typo for website in english translation ### Context of Change Bug introduced in #1056 ### Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ### TypeScript/Hooks Update - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
In order to improve the usability of the search bar inside of Explorer, matching tokens will now auto-populate as a user is typing. The results are clickable and redirect to the respective token page. The data is pulled from XRPLMeta and cached inside of the Explorer backend to display an open sourced list of tokens and relevant statistics.
Backend changes implement serverside caching of tokens data from XRPL Meta, and exposes an API from the explorer backend for search result querying. This is less expensive than the previous approach of websockets (which remain open for the duration of a user session) and are susceptible to rate limits on XRPLMeta's public node infrastructure. This also offers resilience in the case that the public XRPLMeta node has downtime.
Desktop:
Mobile:
Context of Change
Type of Change
TypeScript/Hooks Update
Before / After
Test Plan