Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid initializing multiple connections #1096

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Dec 2, 2024

High Level Overview of Change

Title says it all. There are multiple connections made to a node in the current implementation, at different ports (which all forward to the same place on livenet). While the connection isn't sustained, it still has to be made and canceled.

Context of Change

There is a lot of load on s2 right now, so saving a connection or two might make a difference.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

TypeScript/Hooks Update

N/A

Before / After

Test Plan

Tested locally.

@mvadari mvadari requested review from ckniffen and pdp2121 December 2, 2024 22:31
@mvadari mvadari merged commit 1e89d53 into staging Dec 2, 2024
4 checks passed
@mvadari mvadari deleted the duplicate-connection branch December 2, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants