fix: fix OfferCreate price visual #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
approved these changes
Oct 2, 2023
|
Looks like there is an extra space between the |
Yeah, I'm not sure where that came from/how to get rid of it. |
1 task
mvadari
added a commit
that referenced
this pull request
Oct 3, 2023
## High Level Overview of Change The bottom margin in the Price row in Simple was too much, and there was extra spacing between the currency pair in the TableDetail. This PR fixes those issues. ### Context of Change Follow up from #841 ### Type of Change - [x] Bug fix (non-breaking change which fixes an issue) ### TypeScript/Hooks Update N/A ## Before / After ### Before <img width="762" alt="image" src="https://github.com/ripple/explorer/assets/8029314/41727f1b-730e-49de-9c81-e3186b1bb298"> <img width="494" alt="image" src="https://github.com/ripple/explorer/assets/8029314/dbebdb45-7262-41a7-8097-bf0241d366fe"> ### After <img width="762" alt="image" src="https://github.com/ripple/explorer/assets/8029314/e51aa619-e742-4c82-a317-32e0499b37c0"> <img width="494" alt="image" src="https://github.com/ripple/explorer/assets/8029314/918989ff-e676-4618-b0c5-87d688a075f4"> ## Test Plan Works locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR fixes an issue where prices showed up weirdly on the
OfferCreateprice currency pair.Context of Change
Noticed while working on #839
Type of Change
TypeScript/Hooks Update
N/A
Before / After
Before
After
Test Plan
Works locally.