Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB3-166: Commit Chain Configuration to Journal #281

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Oct 4, 2024

Currently, Steel allows flexible chain configurations but doesn't commit them to the journal. This can lead to:

  • Accidental execution on the wrong chain (e.g., Sepolia spec on mainnet).
  • Difficulty in verifying the integrity of custom configurations.

This PR resolves these issues by hashing the chain configuration and including it in the Steel Commitment. This ensures transparency and prevents potential security risks.

@Wollac Wollac self-assigned this Oct 4, 2024
@github-actions github-actions bot changed the title Add config ID WEB3-166: Add config ID Oct 4, 2024
@Wollac Wollac marked this pull request as ready for review October 4, 2024 16:09
@Wollac Wollac requested a review from capossele as a code owner October 4, 2024 16:09
@Wollac Wollac requested a review from a team as a code owner October 4, 2024 16:18
@Wollac Wollac changed the title WEB3-166: Add config ID WEB3-166: Commit Chain Configuration to Journal Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants