Using '--with-profiles' replace '--with-isa-spec'. #1760
+32
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kito-cheng
reviewed
Aug 28, 2025
There was a problem hiding this comment.
Keep --with-isa-spec option and drop that from document and issue obsolete message,
Also don't pass anything to gcc's configuration argument if --with-profiles for compatibility.
And I think it's kind of not reasonable set rva23u64 for baremetal toolchain.
Last, I guess we should document the relation between --with-arch? (e.g. the priority between --with-profile and --with-arch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace
--with-isa-specoption by using--with-profiles, currently the RISC-V Profiles is more widely use than--with-isa-spec, drop the--with-isa-specand using--with-profiles.Waiting for GCC 16 release to actually supporting this.