Rewrite the far branches section #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apazos
reviewed
Feb 27, 2025
src/asm-manual.adoc
Outdated
| with its offset. As such a unconditional branch to the target is added and the | ||
| original instruction replaced with a conditional branch with inverted conditions | ||
| to jump over this new instruction. As such the final assembled binary contains | ||
| the following: |
There was a problem hiding this comment.
Thanks for improving the text readability, @simonpcook
To avoid repeating "As such" maybe we can say "Consequently, the final assembled binary contains the following:"
There was a problem hiding this comment.
Thanks for the suggestion, I've updated this PR to match
simonpcook
force-pushed
the
spc-farbranches
branch
from
a49de9a to
0865245
Compare
During the latest Toolchain SIG meeting it was raised that this section does not make its intent and behavior clear enough. This rewords the prose to explain what is going on in more detail.
simonpcook
force-pushed
the
spc-farbranches
branch
from
0865245 to
18ec435
Compare
|
Added a review, hope this helps! |
|
Thanks for the great rewrite! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the latest Toolchain SIG meeting it was raised that this section does not make its intent and behavior clear enough. This rewords the prose to explain what is going on in more detail.