Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images directory #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

QuanDool
Copy link

The images were not loaded as the images folder has been moved up one level. After the change, the images are now visible.

Signed-off-by: QuanDool <107268443+QuanDool@users.noreply.github.com>
@atishp04
Copy link
Collaborator

atishp04 commented Apr 8, 2024

The changes won't work as the the Makefile builds the images from the parent directory. Here are the build errors

asciidoctor: WARNING: image to embed not found or not readable: /home/atish/workspace/specs/images/riscv-sbi-intro1.png
asciidoctor: WARNING: image to embed not found or not readable: /home/atish/workspace/specs/images/riscv-sbi-intro2.png
asciidoctor -d book -b html riscv-sbi.adoc
asciidoctor: WARNING: optional gem 'pygments.rb' is not available (reason: cannot load 'pygments'). Functionality disabled.
asciidoctor: WARNING: image to embed not found or not readable: /home/atish/workspace/specs/images/riscv-sbi-intro1.png
asciidoctor: WARNING: image to embed not found or not readable: /home/atish/workspace/specs/images/riscv-sbi-intro2.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants