Add SBI_ERR_FAILED to several functions #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Event injection depends on platform-specific support which may fail or any number of reasons. Provide a catch-all error to the function which may be used in those cases. Reviewed-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Functions which take physical addresses return SBI_ERR_INVALID_ADDRESS for address parameters or address parameter plus size parameter inputs which result in invalid physical addresses with respect to the platform's physical memory layout. Also provide these functions SBI_ERR_FAILED which may be used for addresses that the specific SBI implementation does not support. It should be less confusing to S-mode to get a generic error than an invalid address error for addresses which S-mode is sure are valid. Also add a new specification to return SBI_ERR_INVALID_ADDRESS for invalid physical addresses and non-normative text stating when SBI_ERR_FAILED may be returned instead. Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
jones-drew
force-pushed
the
add-failed-err
branch
from
f1a0951
to
d906e39
Compare
|
Closing the PR as the patches are merged from the mailing list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many functions need SBI_ERR_FAILED with the generic "...failed for
unspecified or unknown other reasons" meaning since SBI implementations
can fail for many [SBI-specific] reasons and it's not reasonable to try
and enumerate them all. A quick audit found the main need is by
functions which take physical address parameters since SBI implementations
may fail on addresses which S-mode knows to be valid (per the platform's
memory layout and ISA), but are not valid for the specific SBI
implementation. Also during the quick audit one SSE function was
identified as needing SBI_ERR_FAILED since event injection has lots of
moving parts.