Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that not all MOP.RR.7 or MOP.R.28 encodings are used for Zicfiss #215

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Note that not all MOP.RR.7 or MOP.R.28 encodings are used for Zicfiss #215

merged 4 commits into from
Mar 21, 2024

Conversation

ved-rivos
Copy link
Collaborator

No description provided.

aswaterman
aswaterman reviewed Mar 18, 2024
View reviewed changes
src/cfi_backward.adoc Outdated
Comment on lines 103 to 105
corresponding instruction adheres to its Zimop-defined behavior, unless it is
employed by another extension. In such cases, the instruction follows the
behavior specified by that other extension.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest shortening unless it is employed by another extension. In such cases, the instruction follows the behavior specified by that other extension. to unless redefined by another extension. This matches the language in the Zimop spec and avoids making it seem like this is some kind of special case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswaterman updated. Thanks!

aswaterman
aswaterman approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo my one comment

kasanovic
kasanovic reviewed Mar 19, 2024
View reviewed changes
Copy link

@kasanovic kasanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change "utilized" to "used" to more clearly match the "does not use" in first sentences. It's also shorter.

@ved-rivos
Copy link
Collaborator Author

@kasanovic updated as suggested.

@ved-rivos ved-rivos merged commit c204772 into riscv:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasanovic kasanovic kasanovic left review comments

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ved-rivos @kasanovic @aswaterman