Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud: Document BYOC custom settings #197

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Cloud: Document BYOC custom settings #197

merged 4 commits into from
Jan 15, 2025

Conversation

WanYixian
Copy link
Collaborator

@WanYixian WanYixian commented Jan 13, 2025

Convert this notion page into doc.

See preview here, let me know if any comments, thanks!

@WanYixian WanYixian marked this pull request as draft January 13, 2025 09:50
@WanYixian WanYixian marked this pull request as ready for review January 14, 2025 03:37
Copy link

@lukeraphael lukeraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left one comment

cloud/project-byoc.mdx Outdated Show resolved Hide resolved
cloud/project-byoc.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WanYixian WanYixian merged commit e385cd6 into main Jan 15, 2025
4 checks passed
@WanYixian WanYixian deleted the wyx/byoc-editing branch January 15, 2025 05:55
@WanYixian WanYixian changed the title Document BYOC custom settings Cloud: Document BYOC custom settings Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants