-
Notifications
You must be signed in to change notification settings - Fork 577
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: support
key encode bytes
for sink (#19243)
Co-authored-by: tabversion <tabversion@bupt.icu>
- Loading branch information
1 parent
e1ee22f
commit 8d6c6c2
Showing
7 changed files
with
317 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
// Copyright 2024 RisingWave Labs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use risingwave_common::catalog::Schema; | ||
use risingwave_common::types::DataType; | ||
|
||
use super::RowEncoder; | ||
|
||
pub struct BytesEncoder { | ||
pub schema: Schema, | ||
// the column must contain only one element | ||
pub col_index: usize, | ||
} | ||
|
||
impl BytesEncoder { | ||
pub fn new(schema: Schema, col_index: usize) -> Self { | ||
Self { schema, col_index } | ||
} | ||
} | ||
|
||
impl RowEncoder for BytesEncoder { | ||
type Output = Vec<u8>; | ||
|
||
fn schema(&self) -> &risingwave_common::catalog::Schema { | ||
&self.schema | ||
} | ||
|
||
fn col_indices(&self) -> Option<&[usize]> { | ||
Some(std::slice::from_ref(&self.col_index)) | ||
} | ||
|
||
fn encode_cols( | ||
&self, | ||
row: impl risingwave_common::row::Row, | ||
col_indices: impl Iterator<Item = usize>, | ||
) -> crate::sink::Result<Self::Output> { | ||
// It is guaranteed by the caller that col_indices contains only one element | ||
let mut result = Vec::new(); | ||
for col_index in col_indices { | ||
let datum = row.datum_at(col_index); | ||
let data_type = &self.schema.fields[col_index].data_type; | ||
if data_type == &DataType::Bytea { | ||
if let Some(scalar_impl) = datum { | ||
result = scalar_impl.into_bytea().to_vec(); | ||
} else { | ||
result = vec![]; | ||
} | ||
} else { | ||
return Err(crate::sink::SinkError::Encode(format!( | ||
"Unsupported data type: expected bytea, got {}", | ||
data_type | ||
))); | ||
} | ||
} | ||
|
||
Ok(result) | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod test { | ||
use risingwave_common::catalog::Field; | ||
use risingwave_common::row::OwnedRow; | ||
use risingwave_common::types::ScalarImpl; | ||
|
||
use super::*; | ||
|
||
#[test] | ||
fn test_bytes_encoder_ser_bytes() { | ||
let schema = Schema::new(vec![Field::with_name(DataType::Bytea, "col1")]); | ||
let encoder = BytesEncoder::new(schema, 0); | ||
|
||
let row = OwnedRow::new(vec![Some(ScalarImpl::Bytea(b"some_bytes".to_vec().into()))]); | ||
assert_eq!( | ||
encoder.encode_cols(&row, std::iter::once(0)).unwrap(), | ||
b"some_bytes".to_vec() | ||
); | ||
|
||
let row = OwnedRow::new(vec![None]); | ||
assert_eq!( | ||
encoder.encode_cols(&row, std::iter::once(0)).unwrap(), | ||
Vec::<u8>::new() | ||
); | ||
|
||
let schema = Schema::new(vec![Field::with_name(DataType::Int16, "col1")]); | ||
let encoder = BytesEncoder::new(schema, 0); | ||
let row = OwnedRow::new(vec![Some(ScalarImpl::Int16(123))]); | ||
assert!(encoder.encode_cols(&row, std::iter::once(0)).is_err()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ use crate::sink::Result; | |
|
||
mod avro; | ||
mod bson; | ||
pub mod bytes; | ||
mod json; | ||
mod proto; | ||
pub mod template; | ||
|
Oops, something went wrong.