-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump toolchain to nightly-2024-03-12 #15722
Conversation
Signed-off-by: Richard Chien <stdrc@outlook.com>
…AVE NO IDEA WHAT I DID)
…-rust Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Blocked by risingwavelabs/jsonbb#3 |
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
All tests pass now. Only fmt/clippy issues. |
This error raises after merge main.
|
…-rust Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storage part LGTM!
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Oops. It seems we do this chore work duplicately. 🤪 |
:) No worries, I will close mine, seems like it's finally close to being done |
Signed-off-by: xxchan <xxchan22f@gmail.com>
cc @zwang28 Do you have any ideas?
|
The failure can be triggered by madsim bump. #16760 |
This looks good. I think we can merge after madsim issue is resolved. |
Seems good to go? |
Let's go! |
Signed-off-by: Richard Chien stdrc@outlook.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
There have been quite some changes, so I want to merge now to reduce burden.
Also since we've code freezed for 1.8, so it's a good timing now.
blocker rust-lang/rust#122618(workarounded)Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.