feat: support background DDL for MV on shared source #18919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
xxchan
force-pushed
the
xxchan/share-source-config
branch
from
1ba3525
to
16e430d
Compare
xxchan
force-pushed
the
10-15-feat_support_background_ddl_for_mv_on_shared_source
branch
from
651dd45
to
3bb6e7b
Compare
xxchan
force-pushed
the
xxchan/share-source-config
branch
from
16e430d
to
5282fa9
Compare
xxchan
force-pushed
the
10-15-feat_support_background_ddl_for_mv_on_shared_source
branch
from
3bb6e7b
to
4b11a81
Compare
xxchan
force-pushed
the
xxchan/share-source-config
branch
from
5282fa9
to
6ed05a4
Compare
xxchan
force-pushed
the
10-15-feat_support_background_ddl_for_mv_on_shared_source
branch
from
4b11a81
to
ec97955
Compare
xxchan
force-pushed
the
xxchan/share-source-config
branch
from
6ed05a4
to
14e84ce
Compare
xxchan
force-pushed
the
10-15-feat_support_background_ddl_for_mv_on_shared_source
branch
from
ec97955
to
13e0d77
Compare
9 tasks
xxchan
force-pushed
the
10-15-feat_support_background_ddl_for_mv_on_shared_source
branch
from
13e0d77
to
30c3895
Compare
9 tasks
|
kindly ping reviewers here |
|
Will have a look by today |
BugenZhao
approved these changes
Oct 17, 2024
Comment on lines
+380
to
+381
| /// Some other leaf nodes like `StreamValues` do not support recovery, and they | ||
| /// cannot use background ddl. |
There was a problem hiding this comment.
Do we have an issue for this? Is it possible to address this by simply recording the state into a state table?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
xxchan
deleted the
10-15-feat_support_background_ddl_for_mv_on_shared_source
branch
xxchan
added a commit
that referenced
this pull request
Oct 17, 2024
kwannoel
reviewed
Oct 17, 2024
| pub(crate) fn plan_has_backfill_leaf_nodes(plan: &PlanRef) -> bool { | ||
| /// Some other leaf nodes like `StreamValues` do not support recovery, and they | ||
| /// cannot use background ddl. | ||
| pub(crate) fn plan_can_use_backgronud_ddl(plan: &PlanRef) -> bool { |
kwannoel
reviewed
Oct 17, 2024
| if plan.inputs().is_empty() { | ||
| if let Some(scan) = plan.as_stream_table_scan() { | ||
| if plan.as_stream_source_scan().is_some() { |
There was a problem hiding this comment.
For stream_source_scan it is only used by source backfill right? If so this LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
follow up of #18112, where we only implemented the track mechanism in meta, but it's banned in frontend
#18338
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.