refactor: move server.id for MySQL CDC from meta to fe #19169
Merged
+18
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
xxchan
force-pushed
the
xxchan/desirable-trout
branch
3 times, most recently
from
0399933
to
fa620ec
Compare
xxchan
force-pushed
the
xxchan/desirable-trout
branch
2 times, most recently
from
9f4c672
to
2cab4a1
Compare
9 tasks
xxchan
force-pushed
the
xxchan/desirable-trout
branch
from
2cab4a1
to
f59bc27
Compare
StrikeW
reviewed
Oct 30, 2024
motivation is to simplify create stream job process in meta Signed-off-by: xxchan <xxchan22f@gmail.com>
BugenZhao
reviewed
Nov 1, 2024
| @@ -1465,6 +1466,14 @@ pub fn bind_connector_props( | |||
| .to_string(), | |||
| ); | |||
| } | |||
| if !is_create_source && with_properties.is_mysql_cdc_connector() { | |||
| // Generate a random server id for mysql cdc source if needed | |||
| // `server.id` (in the range from 1 to 2^32 - 1). This value MUST be unique across whole replication | |||
There was a problem hiding this comment.
How do we ensure uniqueness by generating a random number locally?
There was a problem hiding this comment.
We don't guarantee uniqueness, this is just a side note.
There was a problem hiding this comment.
this is just a side note
I don't quite get this. So will this be a problem?
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
force-pushed
the
xxchan/desirable-trout
branch
from
f59bc27
to
06fd5cb
Compare
xxchan
commented
Nov 1, 2024
| @@ -45,7 +45,6 @@ create source s with ( | |||
| username = 'shared-cdc', | |||
| password = 'abcdef', | |||
| database.name = 'testdb1', | |||
| server.id = '114514' | |||
There was a problem hiding this comment.
Manually tested that before this PR, this test will fail if server.id not specified
StrikeW
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
motivation is to simplify create stream job process in meta (prepare for #19171, where we will completely remove
fill_table_stream_graph_info)Also made a behavior change: previously, auto assign
server.idwill only for legacyCREATE TABLECDC, but not sharedCREATE SOURCE.previous work: #13031
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.