Refactor: Change ALTER FRAGMENT SET RATE_LIMIT to support specific rate limit types #23997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The previous
ALTER FRAGMENT SET RATE_LIMIThad ambiguous semantics when a fragment has both sink and backfill rate limits. This PR decouples the singleRATE_LIMITinto four specific types.New syntax:
Changes:
AlterFragmentOperationenum: replacedAlterBackfillRateLimitwith four specific variants (SetBackfillRateLimit,SetSourceRateLimit,SetDmlRateLimit,SetSinkRateLimit)parse_alter_fragment_rate_limitPbThrottleTarget::FragmentbackendChecklist
Documentation
Release note
Breaking change:
ALTER FRAGMENT <id> SET RATE_LIMITsyntax has been replaced with specific rate limit types:ALTER FRAGMENT <id> SET BACKFILL_RATE_LIMIT TO <value>ALTER FRAGMENT <id> SET SOURCE_RATE_LIMIT TO <value>ALTER FRAGMENT <id> SET DML_RATE_LIMIT TO <value>ALTER FRAGMENT <id> SET SINK_RATE_LIMIT TO <value>Original prompt
ALTER FRAGMENT SET RATE_LIMITtoALTER FRAGMENT SET (BACKFILL_RATE_LIMIT | SOURCE_RATE_LIMIT | DML_RATE_LIMIT | SINK_RATE_LIMIT)#23996✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.