refactor(error): use provide functionality from thiserror-ext to avoid patching thiserror
#24008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
RW's codebase is using a forked git dep of
thiserror 2.0.12(#22304) for implementing theError::providefor Postgres error code. However, maintaining it seems to be a burden.This PR refactors the impl to use the
extra_providefunctionality fromthiserror-ext, instead of modifying the expansion output ofthiserror. As a result, a boxed new type is required forCatalogError.Checklist
Documentation
Release note