Skip to content

Conversation

@hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Dec 5, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Prior to this PR, bloom filter will be lost after serde because:

  1. the bloom filter field is "take" from meta into filter_reader in Sstable::new:
    let filter_reader = XorFilterReader::new(&filter_data, &meta.block_metas);
  2. Sstable serialization skips filter_reader and serializes meta only, which contains empty bloom filter because of 1
  3. Sstable deserialization reconstructs filter_reader via Sstable::new from meta, which results in empty `filter_reader.

That means when a sstable is written to the disk meta cache, the bloom filter is cleared.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@hzxa21 hzxa21 requested review from Li0k and MrCroxx December 5, 2025 17:25
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Dec 5, 2025
hzxa21 added a commit that referenced this pull request Dec 5, 2025
@hzxa21 hzxa21 added the ci/run-compaction-test trigger compaction-test on Buildkite label Dec 5, 2025
@risingwave-ci
Copy link

Failed: 0
Passed:1
FailedExecutions:

PassedExecutions:
https://buildkite.com/risingwave-test/compaction-test/builds/362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/run-compaction-test trigger compaction-test on Buildkite type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants