fix: fix sstable serde to avoid losing bloom filter #24025
+55
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Prior to this PR, bloom filter will be lost after serde because:
metaintofilter_readerinSstable::new:risingwave/src/storage/src/hummock/sstable/mod.rs
Line 154 in 02b595c
filter_readerand serializesmetaonly, which contains empty bloom filter because of 1filter_readerviaSstable::newfrommeta, which results in empty `filter_reader.That means when a sstable is written to the disk meta cache, the bloom filter is cleared.
Checklist
Documentation
Release note