Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows viewer #339

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Windows viewer #339

wants to merge 6 commits into from

Conversation

luigi-rosso
Copy link
Collaborator

Exploring what support for a Windows viewer would look like.

Currently required creating a separate build folder for Windows with its own Premake. I've done a better job in other projects (like rive-unity) of maintaining one premake5.lua for all environments. Our current one in this repo is just a little too funky to patch for this (we import multiple premake scripts and they each sort of do their own thing to try to be OS-agnostic, but none of them really do it well).

Only real code change is the need to supply "b" to fopen on Windows. The rest of it is config and dependency retrieval/building.

Readme with requirements here: https://github.com/rive-app/rive-cpp/tree/windows_viewer/skia/viewer/build/windows

@luigi-rosso
Copy link
Collaborator Author

Oh this new gmtime stuff is throwing windows as gmtime_r isn't availbale there. I'm going to ifdef this out as it should be experimental anyway.

Copy link
Contributor

@mikerreed mikerreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try running this locally on my windows box

@luigi-rosso luigi-rosso marked this pull request as ready for review June 20, 2022 17:03
@luigi-rosso
Copy link
Collaborator Author

I'd like to land this so the Noesis team can keep using it. It's not an ideal build system design but it does unblock an important initiative.

@madoodia
Copy link

thanks @luigi-rosso
but how to build rive-cpp for windows?
if we want to use it as a third party library in our application?
there is any way to build it on windows?
please let me know!

@jebos
Copy link

jebos commented Oct 24, 2023

I build it on Windows in our RiveQtQuickPlugin.

Since Qt uses cmake, I basically just created simple cmakelists files out of source and avoid using premake5.

With that I can build it with visual studio compiler, gcc (with a small patch), clang,...

Just take a look at the repo.

@madoodia
Copy link

Thanks @jebos
I'll take a look to see how did you compile rive-cpp as a third party to your project
I'll ask upcoming questions, if you answer It would be great!
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants