fix(rivet/resolver): avoid clash of name of fields and symbols

cmd/src/tools/cmd_fmt.ri

@@ -6,7 +6,6 @@ import std/flag;
 import std/console;
 import std/fs.Directory;
 
-import rivet;
 import rivet/ast;
 import rivet/fmt;
 import rivet/prefs;

lib/rivet/src/resolver/decls.ri

@@ -160,9 +160,19 @@ extend Resolver {
                     }
                     self.resolve_decls(extend_decl.decls);
                 },
-                .Field(mut field_decl) -> if self.resolve_type(field_decl.type)
-                    && field_decl.has_def_expr {
-                    self.resolve_expr(field_decl.def_expr);
+                .Field(mut field_decl) -> if self.resolve_type(field_decl.type) {
+                    if field_decl.has_def_expr {
+                        self.resolve_expr(field_decl.def_expr);
+                    }
+                    if sym := self.self_sym.scope.find(field_decl.name) {
+                        report.error(
+                            "{} `{}` has field and {} named `{}`".fmt(
+                                self.self_sym.type_of(), self.self_sym.name, sym.type_of(), field_decl.name
+                            ), 
+                            field_decl.pos
+                        );
+                        continue;
+                    }
                 },
                 .Func(mut func_decl) -> {
                     if func_decl.is_method {

lib/std/src/backtrace/mod.ri

@@ -5,6 +5,6 @@
 import core;
 
 #[inline]
-pub func print(frames_to_skip: int32 = 0) {
+pub func print(frames_to_skip: int32 := 0) {
     core.bt_print(frames_to_skip);
 }

lib/std/src/dynlib/mod.ri → lib/std/src/dynlib/mod.c.ri

@@ -8,16 +8,16 @@
 
 import c/libc;
 
-pub var sharedLibExtension := get_shared_library_extension();
+pub var shared_lib_extension := get_shared_library_extension();
 
 /// Returns a library name with the operating system specific extension for shared
 /// libraries.
 #[inline]
 pub func library_name(libname: string) -> string {
-    return if libname.ends_with(sharedLibExtension) {
+    return if libname.ends_with(shared_lib_extension) {
         libname
     } else {
-        libname.concat(sharedLibExtension)
+        libname.concat(shared_lib_extension)
     };
 }
 
@@ -39,8 +39,8 @@ pub struct CannotLoadLibraryError < Throwable {
     }
 }
 
-pub func load(path: string, global_symbols: bool = false) -> !Library {
-    flags := if global_symbols { libc.RTLD_NOW | libc.RTLD_GLOBAL } else { libc.RTLD_NOW };
+pub func load(path: string, global_symbols: bool := false) -> !Library {
+    flags: int32 := if global_symbols { libc.RTLD_NOW | libc.RTLD_GLOBAL } else { libc.RTLD_NOW };
     if ptr := unsafe { libc.dlopen(path.ptr, flags) } {
         return Library(path, ptr);
     }

lib/std/src/flag/mod.ri

@@ -66,7 +66,7 @@ pub struct FlagParser {
     mut application_description: string;
     mut args_description: string;
     /// Whether passing undescribed arguments is allowed.
-    mut allow_unknown_args: bool;
+    mut allow_unknown_args_: bool;
     /// When set, --help will display all the collected footers at the bottom.
     mut footers: []string;
 
@@ -184,7 +184,7 @@ pub struct FlagParser {
     /// to fail.
     #[inline]
     pub func allow_unknown_args(mut self) {
-        self.allow_unknown_args = true;
+        self.allow_unknown_args_ = true;
     }
 
     /// Returns an option with the bool value of the given command line flag, named `name`.
@@ -325,7 +325,7 @@ pub struct FlagParser {
     pub func finalize(mut self) -> ![]string {
         self.handle_builtin_options();
         mut remaining := self.args.clone();
-        if !self.allow_unknown_args {
+        if !self.allow_unknown_args_ {
             for arg in remaining {
                 if (arg.len >= 2 && arg.substr(end: 2) == "--")
                     || (arg.len == 2 && arg[0] == '-') {

lib/std/src/math/mod.ri

@@ -19,7 +19,7 @@ pub const LN10: float64 := 2.302585092994045684017991454684364207601101488628772
 pub const LOG10_E: float64 := 1.0 / LN10;
 
 /// Returns the number of digits in the number passed.
-pub func count_digits(number: int64) -> int32 {
+pub func count_digits(number: int) -> int {
 	if number == 0 {
 		return 1;
 	}

tests/invalid/clash_of_name_of_fields_and_symbols.out

@@ -0,0 +1,4 @@
+tests/invalid/clash_of_name_of_fields_and_symbols.ri:2:5: error: struct `Xyz` has field and function named `a`
+    2 |     a: int;
+      |     ^~~~~~
+rivet: error: could not compile module `clash_of_name_of_fields_and_symbols`, aborting due to previous error

tests/invalid/clash_of_name_of_fields_and_symbols.ri

@@ -0,0 +1,5 @@
+struct Xyz {
+    a: int;
+
+    func a() {}
+}