Upgrade rules_file #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmoon
reviewed
Dec 22, 2023
WORKSPACE.bazel
Outdated
|
|
||
| http_archive( | ||
| name = "rules_file", | ||
| sha256 = "9108bf11fe1063bb6268f15506ea35c1a29e03cae651032d1da3d0f33561c5fd", | ||
| sha256 = "ee31f2ebcd09e289090420012d19ffaecb71c005e74f511301f1fd47cbd5f971", | ||
| strip_prefix = "rules_file-%s" % FILE_VERSION, | ||
| url = "https://github.com/hello-seer/rules_file/archive/%s.zip" % FILE_VERSION, |
There was a problem hiding this comment.
We have rules_javascript's rules_file pulling from a fork of rivet's rules_file. Feels kind of messy, what's going on?
There was a problem hiding this comment.
Ah, didn't realize, we just need to put those changes back into Rivet's.
I'll look at that.
There was a problem hiding this comment.
The changes were already in rivethealth/rules_file. I updated the URL to use that.
Ignore GNU untar header errors
pauldraper
force-pushed
the
pauldraper/rules-file
branch
from
ca20222 to
25d622b
Compare
nathanmoon
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore GNU untar header errors