Merge pull request #33 from camel-cdr/cosmetic

fix extern/const usage and remove unused variables

include/rvvlm.h

@@ -577,11 +577,10 @@ union sui64_fp64 {
 #define RVVLM_TANHDI_STD rvvlm_tanhI
 
 // Define the various tables for table-driven implementations
-extern int64_t expD_tbl64_fixedpt[64];
-extern int64_t logD_tbl128_fixedpt[128];
-extern double logtbl_4_powD_128_hi_lo[256];
-extern double dbl_2ovpi_tbl[28];
-extern int64_t factorial_fixedpt[180];
+extern const int64_t expD_tbl64_fixedpt[64];
+extern const int64_t logD_tbl128_fixedpt[128];
+extern const double logtbl_4_powD_128_hi_lo[256];
+extern const double dbl_2ovpi_tbl[28];
 
 // Define the functions in the vector math library
 void RVVLM_ACOSD_FIXEDPT(size_t x_len, const double *x, double *y);

include/rvvlm_asinhcoshD.inc.h

@@ -37,7 +37,7 @@
 // which is computed with care.
 void F_VER1(API) {
   size_t vlen;
-  VFLOAT vx, vx_orig, vy, vy_special;
+  VFLOAT vx, vy, vy_special;
   VBOOL special_args;
 
   SET_ROUNDTONEAREST;
@@ -46,7 +46,7 @@ void F_VER1(API) {
     vlen = VSET(_inarg_n);
     vx = VFLOAD_INARG1(vlen);
 #if defined(COMPILE_FOR_ASINH)
-    vx_orig = vx;
+    VFLOAT vx_orig = vx;
 #endif
 
 #if defined(COMPILE_FOR_ACOSH)

include/rvvlm_atan2D.inc.h

@@ -213,8 +213,8 @@ void F_VER1(API) {
       divide = __riscv_vmandn(divide, x_neg, vlen);
       divide = __riscv_vmand(divide, exp_diff_large, vlen);
 
-      VFLOAT abs_y = __riscv_vfsgnj(vy, fp_posOne, vlen);
 #if defined(COMPILE_FOR_ATAN2)
+      VFLOAT abs_y = __riscv_vfsgnj(vy, fp_posOne, vlen);
       VFLOAT tmp1 = __riscv_vfdiv(divide, abs_y, vx, vlen);
       tmp1 = __riscv_vfmerge(tmp1, 0x1.0p-60, no_divide, vlen);
       tmp1 = __riscv_vfsgnj(tmp1, vx, vlen);

include/rvvlm_atanD.inc.h

@@ -76,7 +76,7 @@ static_assert(false, "Must specify atan or atanpi" __FILE__);
 // r and s into fixed point.
 void F_VER1(API) {
   size_t vlen;
-  VFLOAT vx_orig, vx, vy, vy_special;
+  VFLOAT vx_orig, vy, vy_special;
   VBOOL special_args;
 
   SET_ROUNDTONEAREST;

include/rvvlm_erfcD.inc.h

@@ -89,7 +89,7 @@ static_assert(false,
 // cdfnorm(|x|) = 1 - cdfnorm(-|x|)
 void F_VER1(API) {
   size_t vlen;
-  VFLOAT vx, vx_orig, vy, vy_special;
+  VFLOAT vx, vx_orig, vy_special;
   VBOOL special_args;
 
   SET_ROUNDTONEAREST;

include/rvvlm_expint1D.inc.h

@@ -203,7 +203,7 @@
 // On return rat_hi and rat_lo are floating-point values
 #define EXPINT1_RAT_GE1(x_hi, x_lo, scale, rat_hi, rat_lo, vlen)               \
   do {                                                                         \
-    VINT P75, P81, P89, Q74, Q81, Q89, Ysq, Y4;                                \
+    VINT P75, P81, P89, Q74, Q81, Q89;                                         \
     VINT _X;                                                                   \
     FLT2FIX((x_hi), (x_lo), (scale), _X, (vlen));                              \
     P75 = PSTEP_I_SLL(P_10, P_11, 1, _X, (vlen));                              \
@@ -242,7 +242,6 @@
     FAST2SUM(_p_tmp2_hi, _p_tmp2_lo, _p_hi, _p_lo, (vlen));                    \
     /* (_p_hi, _p_lo) is an accurate version of p(x) */                        \
                                                                                \
-    VFLOAT AA, aa;                                                             \
     Q74 = PSTEP_I_SLL(Q_10, Q_11, 1, _X, (vlen));                              \
     Q74 = PSTEP_I_SLL(Q_9, _X, 1, Q74, (vlen));                                \
     Q74 = PSTEP_I_SLL(Q_8, _X, 1, Q74, (vlen));                                \
@@ -342,7 +341,7 @@
 
 void F_VER1(API) {
   size_t vlen;
-  VFLOAT vx, vx_sign, vy, vy_special;
+  VFLOAT vx, vy, vy_special;
   VBOOL special_args;
   VINT n_adjust;
 

include/rvvlm_powD.inc.h

@@ -92,6 +92,7 @@
         vy = __riscv_vfmin_mu(current_cases, vy, vy, 0x1.0p53, vlen);          \
         vy = __riscv_vfmax_mu(current_cases, vy, vy, -0x1.0p53, vlen);         \
         VINT y_to_int = __riscv_vfcvt_x(current_cases, vy, vlen);              \
+        /* TODO: y_to_int_fp and y_is_int need to be used */                   \
         VFLOAT y_to_int_fp = __riscv_vfcvt_f(current_cases, y_to_int, vlen);   \
         VBOOL y_is_int = __riscv_vmfeq(current_cases, vy, y_to_int_fp, vlen);  \
         VINT sign_z = __riscv_vsll(y_to_int, 63, vlen);                        \

include/rvvlm_tgammaD.inc.h

@@ -316,7 +316,6 @@ void F_VER1(API) {
       vx_lo = __riscv_vmerge(vx_lo, a_tmp_lo, x_lt_0, vlen);
     }
 
-    VFLOAT y_hi, y_lo;
     VINT n, EXP;
 
     VINT XF = __riscv_vsll(VMVI_VX(1, vlen), 61, vlen);

src/rvvlm_2ovpi_tbl.c

@@ -7,7 +7,7 @@
 
 // This is 2^500 * (2/pi) and the lsb of dbl_2ovpi_tbl[j] is 2^(500-(j+1)*52),
 // j=0,1,...,27
-const extern double dbl_2ovpi_tbl[28] = {
+const double dbl_2ovpi_tbl[28] = {
     0x1.45f306dc9c882p+499,  0x1.4a7f09d5f47d4p+446,  0x1.a6ee06db14ad0p+393,
     -0x1.b0ef1bef806bcp+342, 0x1.8eaf7aef1586cp+290,  0x1.c91b8e909374cp+238,
     -0x1.ff9b6d115f630p+184, 0x1.921cfe1deb1d0p+132,  -0x1.3b5963045df74p+82,

src/rvvlm_acosD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_acosDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_acoshD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_acoshDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_acospiD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_acospiDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_asinD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_asinDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_asinhD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_asinhDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_asinpiD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_asinpiDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_atan2D.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_21

src/rvvlm_atan2DI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_21

src/rvvlm_atan2piD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_21

src/rvvlm_atan2piDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_21

src/rvvlm_atanD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_atanDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_atanhD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_atanhDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_atanpiD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_atanpiDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cbrtD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cbrtDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cdfnormD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cdfnormDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cdfnorminvD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cdfnorminvDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cosD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cosDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_coshD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_coshDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cospiD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_cospiDI.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11

src/rvvlm_erfD.c

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #include <riscv_vector.h>
-#include <stdio.h>
 
 #include "rvvlm.h"
 #define API_SIGNATURE API_SIGNATURE_11