Fix the setting of the rounding mode #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhenry
force-pushed
the
dev/ludovic/fix-set-rounding-mode
branch
3 times, most recently
from
d4f485b
to
2d81e81
Compare
It would previously read the rounding mode, but wouldn't set it when it was not TONEAREST. That would work in most cases because TONEAREST is the default rounding mode in a process, and none of our tests would set it differently anyway.
luhenry
force-pushed
the
dev/ludovic/fix-set-rounding-mode
branch
from
2d81e81
to
5e1a45c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would previously read the rounding mode, but wouldn't set it when it was not TONEAREST.
That would work in most cases because TONEAREST is the default rounding mode in a process, and none of our tests would set it differently anyway.