Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use googletest to run tests #20

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Use googletest to run tests #20

merged 2 commits into from
Feb 16, 2024

Conversation

luhenry
Copy link
Collaborator

@luhenry luhenry commented Feb 15, 2024

No description provided.

@luhenry luhenry force-pushed the dev/ludovic/googletest branch 2 times, most recently from 5568225 to f950326 Compare February 15, 2024 16:28
keeranroth
keeranroth requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@keeranroth keeranroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Maybe most of them are moot, if there is going to be another commit which does some more of the testing, and this patch set is just to get googletest into the project

@luhenry luhenry force-pushed the dev/ludovic/googletest branch from f950326 to 2001ea8 Compare February 16, 2024 12:00
@luhenry luhenry force-pushed the dev/ludovic/googletest branch from 2001ea8 to c464480 Compare February 16, 2024 12:05
luhenry
luhenry commented Feb 16, 2024
View reviewed changes
CMakeLists.txt
)

add_library(vecm
${PROJECT_SOURCES}
)

target_include_directories(vecm
PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/include
PUBLIC
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from PRIVATE to PUBLIC so that any project that links against veclibm will automatically have the include for compilation.

@luhenry luhenry merged commit 5077d83 into main Feb 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keeranroth keeranroth keeranroth approved these changes

@PingTakPeterTang PingTakPeterTang Awaiting requested review from PingTakPeterTang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luhenry @keeranroth