feat: add support for excluding OS #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aauren
commented
Oct 1, 2024
Allows the user to specify a list of excluded OS's for a given release. Which is particularly useful for avoiding errors when repos don't support a specific OS. Signed-off-by: Aaron U'Ren <aauren@gmail.com>
aauren
force-pushed
the
add_exclude_os_config
branch
from
396a55f to
a76f74e
Compare
rjbrown57
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to specify a list of excluded OS's for a given release. Which is particularly useful for avoiding errors when repos don't support a specific OS.
Not sure what you'll think of this one, feel free to reject it if you don't like the changes, or would prefer this to be done a different way.
I also changed common error types to be evaluated by an actual Error interfaces rather than their message strings to make the pattern a bit more extensible and so that people didn't have to guess where error strings were being evaluated.