Improved ESM support for all public packages for vitest #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
force-pushed
the
improve-esm-exports
branch
4 times, most recently
from
9a86802 to
dcfaf1c
Compare
- Updated the building of ESM modules to run `tsc-alias` to append the `.js` extensions onto the imports for ESM builds - For those builds that use `lodash` also added a replacer for the `tsc-alias` that switches things to use `lodash-es`
heath-freenome
force-pushed
the
improve-esm-exports
branch
from
dcfaf1c to
0113a44
Compare
heath-freenome
changed the title
schen-fn
approved these changes
Mar 5, 2025
edDoganFreenome
approved these changes
Mar 5, 2025
MarekBodingerBA
added a commit
to bratislava/konto.bratislava.sk
that referenced
this pull request
Mar 6, 2025
MarekBodingerBA
added a commit
to bratislava/konto.bratislava.sk
that referenced
this pull request
Mar 6, 2025
* Update RJSF to latest version * RJSF alias not needed anymore rjsf-team/react-jsonschema-form#4510 * Fix wrong import * Don't suggest RJSF and Ajv updates * Add openapi-clients to dependabot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
According to this vitest discussion we needed to add
exportsto allpackage.jsonfilestsc-aliasto append the.jsextensions onto the imports for ESM buildslodashalso added a replacer for thetsc-aliasthat switches things to uselodash-esChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.