Remove SteamManager call to DontDestroyOnLoad when component is not at root hierarchy. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the SteamManager was not at the root of the scene hierachy.
rlabrecque
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Issue where a freeze on the main thead was occuring in il2cpp when the SteamManager was not at the root of the scene hierachy.
Calling DontDestroyOnLoad on an object that is not at the root of the hierarchy is not handled well by Unity, it generates a freeze on the main thread (specially on il2cpp targets) and a warning.
The fix in this MR does not call DontDestroyOnLoad if the game object is not at the root of the hierarchy to not take any reponsability on other objects. Another way to fix this issue can be to call DontDestroyOnLoad on the parent object (the one at the root of the hierarchy) or to assert that it is impossible to put this script on a child object.