fix: Gracefully skip overlong prompts during training to prevent crashes#280
Open
erranlli wants to merge 2 commits intorllm-org:mainfrom
Open
fix: Gracefully skip overlong prompts during training to prevent crashes#280erranlli wants to merge 2 commits intorllm-org:mainfrom
erranlli wants to merge 2 commits intorllm-org:mainfrom
Conversation
Contributor
|
in generate_agent_trajectories_async() Because And then in generate_agent_trajectory() is not necessary |
fda3768 to
25577bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements graceful degradation for prompts exceeding
max_prompt_length, preventing training crashes.Problem
Training crashed when prompts exceeded max length: Exception: Trajectory {idx}: initial prompt length 3302 already exceeded max_prompt_length 2048, retrying
Solution
Noneand are skipped gracefullyKey Changes
agent_execution_engine.py: ReturnNonefor overlong prompts instead of crashingagent_ppo_trainer.py: Track skipped indices and filter batch to matchBenefits
Testing
Expected: Training continues with warnings when 3302-token prompt is encountered, no crashes.
Files Changed
rllm/engine/agent_execution_engine.py(graceful degradation)rllm/trainer/verl/agent_ppo_trainer.py(batch alignment)