Player preliminary work #1026
Open
Player preliminary work #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmcrackan I've done just a little work on the playlist. I renamed the right side popup window from ProcessQueue to Sidebar and added a tab for "Playlist."
I did my vm implementation mainly in LibationUiBase, and did some work to allow the WinForms side to use viewmodels, namely a ViewModelBase. I added a subclass of DataGridView with a bindable SelectedItem property (why doesn't the base control doesn't have this??) called DataGridViewEx. This should allow a lot more code to be in common with WF/Av.
I also added some Container stuff and an EventAggregator to make it possible to get global stuff (like the PlayerViewModel and the EventAggregator) without using static classes, and in a common way between Winforms and Avalonia. Types are registered in two different RegisterTypes() methods called at startup, one in WinForms and one in Avalonia.