Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Ethers v6 and latest versions of all packages. #255

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

steven2308
Copy link
Member

@steven2308 steven2308 commented Jan 11, 2024

Checklist

  • Verified code additions
  • Updated NatSpec comments (if applicable)
  • Regenerated docs
  • Ran prettier
  • Added tests to fully cover the changes

PR-Codex overview

This PR focuses on updating dependencies and improving code quality.

Detailed summary

  • Updated imports from @nomiclabs/hardhat-ethers to @nomicfoundation/hardhat-ethers.
  • Updated imports from @nomicfoundation/hardhat-chai-matchers to @nomicfoundation/hardhat-toolbox.
  • Updated imports from @typechain/hardhat to @nomicfoundation/hardhat-toolbox.
  • Updated imports from ethers.utils to ethers.parseEther in deploy_catalogUtils.ts.
  • Updated deployment functions from deployed() to waitForDeployment() in multiple scripts.
  • Updated imports from @nomiclabs/hardhat-ethers/signers to @nomicfoundation/hardhat-ethers/signers in multiple test files.
  • Updated imports from ethers.BigNumber to ethers.BigInt in metadata.ts and kanariaUtils.ts.
  • Updated constructor arguments in deployment scripts to use await getAddress() instead of address.
  • Removed unused import of Contract from ownableLock.ts.
  • Added OwnableLockMock import in ownableLock.ts.
  • Updated shouldControlValidMinting function in mintingImpl.ts to use ONE_ETH / 2n instead of ethers.utils.parseEther('0.05').
  • Updated shouldHaveMetadata function in metadata.ts to use Promise<bigint> instead of Promise<BigNumber>.
  • Updated setUpKanariaAsset function in kanariaUtils.ts to use bigint instead of BigNumber.
  • Updated setUpGemAssets function in kanariaUtils.ts to use bigint instead of BigNumber.
  • Updated imports from ethers.utils to ethers.parseEther in deploy_bulkWriter.ts, deploy_renderUtils.ts, deploy_emotable.ts, and deploy_tokenAttributesRepo.ts.
  • Updated deployment functions from deployed() to waitForDeployment() in multiple deployment scripts.

The following files were skipped due to too many changes: scripts/deploy_royaltiesSplitter.ts, test/nestableSecTests.ts, test/behavior/royalties.ts, test/extensions/revealable.ts, package.json, test/implementations/catalog.ts, test/behavior/catalog.ts, test/equippable.ts, test/minifiedEquippable.ts, test/nestableMultiasset.ts, test/extensions/typedMultiasset.ts, test/royaltiesSplitter.ts, test/implementations/premint.ts, test/implementations/base.ts, test/setup/equippableSlots.ts, test/nestable.ts, test/collectionUtils.ts, test/behavior/equippableParts.ts, test/implementations/lazyMintNativeTokenPay.ts, test/extensions/tokenHolder.ts, test/multiasset.ts, test/implementations/lazyMintErc20Pay.ts, test/extensions/reclaimableChild.ts, test/catalogUtils.ts, test/extensions/soulbound.ts, test/extensions/nestableAutoIndex.ts, test/setup/equippableParts.ts, test/behavior/multiasset.ts, test/bulkWriter.ts, test/utils.ts, test/implementations/generalBehavior.ts, test/behavior/equippableAssets.ts, test/behavior/equippableSlots.ts, test/behavior/erc721.ts, test/emotableRepository.ts, test/renderUtils.ts, test/behavior/nestable.ts, test/extensions/tokenAttributesRepository.ts, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@steven2308 steven2308 merged commit aab5112 into dev Jan 11, 2024
4 checks passed
@steven2308 steven2308 deleted the package-updates branch January 11, 2024 20:13
Copy link

Updates to Ethers v6 and latest versions of all packages.

Generated at commit: 8eb44d221cda9d33df61cb63e4c7939105809fe9

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
5
24
29
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Member

@Yuripetusko Yuripetusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants