Skip to content
This repository has been archived by the owner on Aug 24, 2018. It is now read-only.

Sensible default for outputPublicPath #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-burel
Copy link

I am not at all a webpack expert, so this change may not be appropriate. However when writing my own config, I did not need a public path, default being '/'.
So I think we should rely on this default when computing the component path (but once again I am not a webpack expert).

I am not at all a webpack expert, so this change may not be appropriate. However when writing my own config, I did not need a public path, default being '/'.
So I think we should rely on this default when computing the component path (but once again I am not a webpack expert).
@rnicholus
Copy link
Owner

Was this change created to fix a bug of some sort or improve the library, or is this just a "i think it should be this way" type of change?

@eric-burel
Copy link
Author

Hi,
It is more a small improvement. Sometime you don't set the publicPath in your output config, because Webpack provide its own default value (/). So I had to seek for this value and to set it manually in order to use your loader. It is not a bug per se but one should not need to change the output config in order to set a loader.
But I can't guarantee that there is no regression whatsoever, take it as a proposal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants